Refactored code in src/upgrades/1.1.0/user_post_count_per_tid.js #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthani2
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code to reduce the maximum depth of nesting.
Restructured the code to simplify the nested callback structure for updating user post counts per topic identifier (tid), reducing complexity. This was done by simplifying the arrangement of functions and improving readability without changing the core functionality.
The async.each and async.eachSeries functions, were maintained but their syntax and structure were cleaned up to reduce redundancy (solving the maximum depth issue).
The function now works under a single method (directly assigned in the module.exports,) replacing the separate assignment of the action function.
Resolves #28