Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code in src/socket.io/admin/rooms.js #63

Open
wants to merge 10 commits into
base: f24
Choose a base branch
from
Open

Refactor code in src/socket.io/admin/rooms.js #63

wants to merge 10 commits into from

Commits on Sep 2, 2024

  1. refactoring codeof SocketRooms.getAll function to reduce its complex… 

    …ity by seperating it into helper functions in src/socket.io/admins/rooms.js
    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a46416e View commit details
    Browse the repository at this point in the history

  2. inserting prent statment to manually test the refactored code in sr/… 

    …sockets.io/admin/rooms.js
    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    180e909 View commit details
    Browse the repository at this point in the history

  3. adding more print statmeents in src/socket.io/admin/rooms.js file

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5e9869c View commit details
    Browse the repository at this point in the history

  4. fxing indentation

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    cf2965f View commit details
    Browse the repository at this point in the history

  5. fxing indentationagain

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4add120 View commit details
    Browse the repository at this point in the history

  6. fixing errors

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4e70b9b View commit details
    Browse the repository at this point in the history

  7. refactoring code in src/socket.io/admin/rooms.js

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7450c55 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. editing getTopTenTopics function to fix the maintainabillity of the code

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5924872 View commit details
    Browse the repository at this point in the history

  2. saving the file cuz i forgot to save the file and pushed the wrong one

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1e66f2f View commit details
    Browse the repository at this point in the history

  3. fixing indentation in the function getTopTenTopics of rooms.js

    Ghalya AL-Eshaq authored and Ghalya AL-Eshaq committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    04efb42 View commit details
    Browse the repository at this point in the history