Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code for Issue src/meta/config.js #89

Open
wants to merge 7 commits into
base: f24
Choose a base branch
from
Open

Refactoring code for Issue src/meta/config.js #89

wants to merge 7 commits into from

Conversation

rkensouh
Copy link

@rkensouh rkensouh commented Sep 4, 2024 •
edited
Loading

Changed the function in the Sonar cloud warning to decrease complexity. See issue #30

@coveralls
Copy link

coveralls commented Sep 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10874244614

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 82.667%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/meta/configs.js 19 23 82.61%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10550029021: -0.004%
Covered Lines: 22325
Relevant Lines: 25585
💛 - Coveralls

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkensouh @coveralls