generated from CMU-17313Q/NodeBB-f23
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added frontend logic to handle the endorsement feature #15
Open
Steve0012345
wants to merge
6
commits into
main
Choose a base branch
from
Steve0012345/adding-frontend-logic-for-endorsement-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added frontend logic to handle the endorsement feature #15
Steve0012345
wants to merge
6
commits into
main
from
Steve0012345/adding-frontend-logic-for-endorsement-feature
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt/topic/postTools.js
nt/topic/postTools.js
Steve0012345
changed the title
Added frontend logic to handle the endorsement.
Added frontend logic to handle the endorsement feature
Sep 18, 2023
Steve0012345
modified the milestones:
Project 2 - sprint 2 (week one),
Project 2 - sprint 1 (week one)
Sep 18, 2023
Steve0012345
modified the milestones:
Project 2 - sprint 1 (week one),
Project 2 - sprint 1 (week two)
Sep 19, 2023
mrahmatu
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should continue working. The changes are not completed yet. But good job on adding the link and detecting its click!
mrahmatu
added
Sprint 1
These issues must be completed by sprint 1 at least (19th Sep 2023).
In-progress
Not completed yet, progress ongoing.
labels
Sep 19, 2023
mrahmatu
modified the milestones:
Project 2 - sprint 1 (week two),
New milestone for issue#5
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Front-end
Deals with front-end devlopment
In-progress
Not completed yet, progress ongoing.
Sprint 1
These issues must be completed by sprint 1 at least (19th Sep 2023).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited the front-end template files and also defined an event handler to listen for a click event on the endorse button. This fires a hook that manages these independently from the component and I set up the logic on the front end necessary to update the endorsed_by_Instructor field in the backend. This logic is caught by the backend and in turn updates the respective field on the backend.