Adding is resolved to backend #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is invalid, but pulled and resolved by PR #80 . |
mbfannan
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through this pull request I was able to add the isResolved boolean attribute to be included as an attribute for a topic, and this was accomplished by including in select attributes of a topic object to the api in src/topics/create.js. I also tested them through test/topics.js. Resolves #68 .
How the testing was accomplished is through ensuring that the isResolved boolean attribute exists through the test oracle of assertion, where upon the creation of a topic object, the test ensures for the existence of the boolean attribute of isResolved in a topic object. The tests passed locally, however it's important to note that this PR action workflow fails because of issues with coveralls. Thus to ensure the test changes remained valid, they were tested in the test passing PR #80 .