generated from CMU-17313Q/NodeBB-f23
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding frontend backend is urgent connection through composer.js file #82
Merged
LujainAlMansoori
merged 6 commits into
main
from
Adding-frontend-backend-isUrgent-connection
Oct 4, 2023
Merged
Adding frontend backend is urgent connection through composer.js file #82
LujainAlMansoori
merged 6 commits into
main
from
Adding-frontend-backend-isUrgent-connection
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecting frontend to backend
…m run test command
mbfannan
force-pushed
the
Adding-frontend-backend-isUrgent-connection
branch
from
October 4, 2023 13:59
6025f7a
to
d5a0320
Compare
Signed-off-by: mbfannan <[email protected]>
mbfannan
requested review from
LujainAlMansoori
and removed request for
zainabAhm
October 4, 2023 14:10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
This puil request tests failed because of coveralls minute changes noticed in the percentage. However it has been overwritten by necessary changes in the green check PR #87 . |
mbfannan
added
duplicate
This issue or pull request already exists
and removed
enhancement
New feature or request
labels
Oct 4, 2023
This was referenced Oct 5, 2023
LujainAlMansoori
added
incorrect workflow fixed by other pr
this label is for pull requests that were resolved by other prs in terms of the action workflow
and removed
duplicate
This issue or pull request already exists
labels
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
incorrect workflow fixed by other pr
this label is for pull requests that were resolved by other prs in terms of the action workflow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited the file, in file path node_modules/nodebb-plugin-composer-default/static/lib/composer.js. What I did involved finding the button in the form for topic submission, extracting the value, and then assigning a topic to have that extracted value for isUrgent. The type is assumed to be boolean through a conditional. This resolves #62.