Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding frontend backend is urgent connection through composer.js file #82

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

mbfannan
Copy link
Contributor

@mbfannan mbfannan commented Oct 4, 2023

I edited the file, in file path node_modules/nodebb-plugin-composer-default/static/lib/composer.js. What I did involved finding the button in the form for topic submission, extracting the value, and then assigning a topic to have that extracted value for isUrgent. The type is assumed to be boolean through a conditional. This resolves #62.

@mbfannan mbfannan added the enhancement New feature or request label Oct 4, 2023
@mbfannan mbfannan added this to the Sprint 2 milestone Oct 4, 2023
@mbfannan mbfannan self-assigned this Oct 4, 2023
@mbfannan mbfannan force-pushed the Adding-frontend-backend-isUrgent-connection branch from 6025f7a to d5a0320 Compare October 4, 2023 13:59
@mbfannan mbfannan requested review from LujainAlMansoori and removed request for zainabAhm October 4, 2023 14:10
Copy link
Contributor

@LujainAlMansoori LujainAlMansoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@LujainAlMansoori LujainAlMansoori merged commit d58e41a into main Oct 4, 2023
15 checks passed
@mbfannan
Copy link
Contributor Author

mbfannan commented Oct 4, 2023

This puil request tests failed because of coveralls minute changes noticed in the percentage. However it has been overwritten by necessary changes in the green check PR #87 .

@mbfannan mbfannan added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Oct 4, 2023
@LujainAlMansoori LujainAlMansoori linked an issue Oct 5, 2023 that may be closed by this pull request
@LujainAlMansoori LujainAlMansoori added incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow and removed duplicate This issue or pull request already exists labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving PR #82 because theres an x Connect the front end urgent button to the backend isUrgent attribute
2 participants