Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the tests for is resolved c onnection #86

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Adding the tests for is resolved c onnection #86

merged 2 commits into from
Oct 4, 2023

Conversation

LujainAlMansoori
Copy link
Contributor

@LujainAlMansoori LujainAlMansoori commented Oct 4, 2023 •
edited by mbfannan
Loading

This resolves issue #68 . This involved the addition of the testing required for the isResolved connection, and this accomplishes the testing of issue #67 . This fulfills the acceptance criteria because it involves first ensuring that the isResolved is by default false upon topic creation. It then ensures that upon calling functionality that is the same as the route, that the isResolved updates to true immediatlly. This is possible through the use of AJAX, ensuring there's no need to refresh the page. This test passed, and thus the acceptance criteria is fulfilled!

mbfannan
mbfannan reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mbfannan mbfannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mbfannan mbfannan self-requested a review October 4, 2023 17:07
@mbfannan mbfannan merged commit ddb87bb into main Oct 4, 2023
3 of 9 checks passed
mbfannan
mbfannan reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mbfannan mbfannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mbfannan mbfannan added the pull request bug There was an issue with the pull request! label Oct 4, 2023
@mbfannan mbfannan added this to the Sprint 2 milestone Oct 4, 2023
@mbfannan mbfannan added the incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow label Oct 4, 2023
@mbfannan
Copy link
Contributor

mbfannan commented Oct 4, 2023

The issue with the action workflow failing was resolved by PR #87 . This was caused by issues from Sprint 1, and database issues. Where it had to be considered if redis was the DB, it takes boolean as strings. PR #87 considers this.

@LujainAlMansoori LujainAlMansoori removed the incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow label Oct 5, 2023
@LujainAlMansoori LujainAlMansoori linked an issue Oct 5, 2023 that may be closed by this pull request
Resolving PR #86 because theres an x #96
Closed
@LujainAlMansoori LujainAlMansoori added incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow and removed pull request bug There was an issue with the pull request! labels Oct 5, 2023
@LujainAlMansoori LujainAlMansoori mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbfannan mbfannan mbfannan left review comments

Assignees

@LujainAlMansoori LujainAlMansoori

Labels
incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.

Resolving PR #86 because theres an x
2 participants
@LujainAlMansoori @mbfannan