Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Constraint to convert Ints into Float64 in the bounds #13

Merged
merged 7 commits into from
Dec 16, 2023

Conversation

stelmo
Copy link
Member

@stelmo stelmo commented Dec 16, 2023

This is just for convenience, because I keep on forgetting to convert it manually... Thoughts?

@stelmo stelmo requested a review from exaexa December 16, 2023 14:22
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c7496e) 100.00% compared to head (12eb582) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          184       186    +2     
=========================================
+ Hits           184       186    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa
Copy link
Member

exaexa commented Dec 16, 2023

/format

triggered by @exaexa on PR #13
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 47db514

Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

src/constraint.jl Outdated Show resolved Hide resolved
@stelmo
Copy link
Member Author

stelmo commented Dec 16, 2023

/format

triggered by @stelmo on PR #13
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 11b8934

Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k good

@exaexa exaexa merged commit b0b09f0 into master Dec 16, 2023
5 checks passed
@exaexa exaexa deleted the sew-constraint-bounds-take-ints branch December 16, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants