-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
january cleanup #24
january cleanup #24
Conversation
Still a verb, but we've got substitute() already and going nouny there would be hard. Closes #21
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 202 219 +17
=========================================
+ Hits 202 219 +17 ☔ View full report in Codecov by Sentry. |
this is great! Gonna remove about 200 LoC from DiffMet :) |
I'm not sure about the run-time overhead here but I think it might actually simplify the stuff a lot. Certainly removed a lot of type stress. Tests got faster by around 10% here. Closes #17
The remaining issue for 1.0 is the #22 which will need a bit of support from DataStructures. I might make a temporary (slower) version too, will see. I think this is ready now tho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
ok well actually let's add at least a primitive version of the tree_zip... :D |
24d9183
to
fd247fa
Compare
fd247fa
to
328010b
Compare
4f98e14
to
6cbf9e8
Compare
function variables_for(makebound, ts::Tree) | ||
var_idx = 0 | ||
map(ts, Constraint) do x | ||
var_idx += 1 | ||
variable(idx = var_idx, bound = makebound(x)) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. when would I want to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.