january cleanup #24
Merged
january cleanup #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a verb, but we've got substitute() already and going nouny there would be hard. Closes #21
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 202 219 +17
=========================================
+ Hits 202 219 +17 ☔ View full report in Codecov by Sentry. |
|
this is great! Gonna remove about 200 LoC from DiffMet :) |
I'm not sure about the run-time overhead here but I think it might actually simplify the stuff a lot. Certainly removed a lot of type stress. Tests got faster by around 10% here. Closes #17
|
The remaining issue for 1.0 is the #22 which will need a bit of support from DataStructures. I might make a temporary (slower) version too, will see. I think this is ready now tho. |
|
ok well actually let's add at least a primitive version of the tree_zip... :D |
exaexa
force-pushed
the
mk-january-cleanup
branch
from
24d9183
to
fd247fa
Compare
exaexa
force-pushed
the
mk-january-cleanup
branch
from
fd247fa
to
328010b
Compare
exaexa
force-pushed
the
mk-january-cleanup
branch
from
4f98e14
to
6cbf9e8
Compare
stelmo
approved these changes
Jan 5, 2024
Comment on lines
+227
to
+233
| function variables_for(makebound, ts::Tree) | ||
| var_idx = 0 | ||
| map(ts, Constraint) do x | ||
| var_idx += 1 | ||
| variable(idx = var_idx, bound = makebound(x)) | ||
| end | ||
| end |
There was a problem hiding this comment.
i.e. when would I want to use it?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.