Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the trees more easily mutable #9

Merged
merged 4 commits into from
Dec 6, 2023
Merged

make the trees more easily mutable #9

merged 4 commits into from
Dec 6, 2023

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Dec 6, 2023

No description provided.

@exaexa exaexa requested a review from stelmo December 6, 2023 08:44
@exaexa exaexa self-assigned this Dec 6, 2023
@exaexa exaexa marked this pull request as draft December 6, 2023 08:44
Copy link

codecov bot commented Dec 6, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@exaexa exaexa changed the title [wip] make the trees more easily mutable make the trees more easily mutable Dec 6, 2023
@exaexa exaexa marked this pull request as ready for review December 6, 2023 09:23
Copy link
Member

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I requested this feature, but your warnings have scared me. Maybe hang tight on merging, until I look at my other code again to see how much of a pain the non-modifications code is :/

Comment on lines +327 to +328
# - changing any data breaks assumptions on anything that was already derived
# from the data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this makes we scared to actually use the functionality tbh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's the purpose. People will do this automatically without reading the docs, and I want to have a piece of text that clearly says "just don't". :D

@exaexa exaexa merged commit a0b5119 into master Dec 6, 2023
5 checks passed
@exaexa exaexa deleted the mk-mutable branch December 6, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants