Skip to content
This repository has been archived by the owner on Jan 30, 2022. It is now read-only.

[WIP] Added link form as an option. #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reecer62
Copy link
Contributor

@reecer62 reecer62 commented Oct 30, 2018

(Closes #26)
Users now have have the ability to add a link to their talk which will be rendered as a tino dot (should I accept another field for the name of the link?).
Before creating the talk:
beforecreatetalk
With link field filled:
link
After talk is created:
after create talk
If the link field is left blank, it will default to talks.

@reecer62 reecer62 changed the title [WIP] Added link form as an option. (Closes #26) [WIP] Added link form as an option. Oct 30, 2018
Copy link
Member

@lannonbr lannonbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one thing that I am thinking currently is it is easy to just add another row for this as you have done, but have you thought about looking into parsing the desc field and see if it has link in it and if such inject the link?

For a lot of talks, they mainly do not have links so I am not sure if adding a new column for this would be the best solution.

As well, with my approach, given there is no auth other than checking if you are on clarkson's internet, it could be a security risk, but a cool idea could to set up some sort of moderation system for talks that include links and have a maintainer of Talks approve a talk. You could set maybe something up to send a text message with twilio or have a bot in discord request a specific user to approve a talk, but as expected it would take more effort but could be a good learning experience.

I am not pushing to do any one way, but just giving some suggestions that could be done.

@reecer62
Copy link
Contributor Author

reecer62 commented Nov 1, 2018

Some notes I took at the cosi meeting:
Remove link field
Search for link in the description
Render description text as a link
CSS hover over effect for link href
Whitelist certain links as blue if good and red as bad
If red have a confirmation to open link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants