-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intake conversion Compare_SST_SSS_TemperatureSalinity_to_WOA13 #355
base: main
Are you sure you want to change the base?
Intake conversion Compare_SST_SSS_TemperatureSalinity_to_WOA13 #355
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The changes on this notebook are not complete - Cosima Cookbook is still being used. Moving to update. |
@marc-white yes as @julia-neme said, pretty much all of these PRs from @max-anu require substantial modification, not just reviewing. If you'd like to go ahead and make these changes to remove references to the cookbook in this notebook, please do! Many of us have run out of steam for dealing with these broken PRs. |
WOA13 data are also missing from |
Feel free to close some of the PRs if data is missing and there is light at the end of the tunnel! |
Yeah, the recipes that use WOA for now load it manually from |
Keep doing that is fine! |
@navidcy I'm quite happy to keep the PRs open where there are major issues outstanding, I think it's probably the easiest way to keep track of where the updates to each recipe are up to (although we should probably mark any that aren't ready for actual review as DRAFT). @julia-neme I think loading manually from |
definitely we'd like to have everything in the catalog! if you can add them there do it...! I don't know about established authorities... |
Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.
A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.