Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion True_Zonal_Mean #373

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adele-morrison adele-morrison requested review from adele-morrison and removed request for adele-morrison July 1, 2024 04:51
@julia-neme
Copy link
Collaborator

julia-neme commented Aug 5, 2024

Ups, I've deleted my comment trying to edit it. This is a good example of not being able to use intake @dougiesquire. The notebook that used the cookbook opened data and run fast, no problems. This new notebook using intake crashes and can't go past the first plot of zonal_arith_mean. Help is appreciated. Note that I am just reviewing the conversion, I haven't made it myself. There are no kwargs or anything in the .to_dask() function.

@dougiesquire
Copy link
Collaborator

Thanks @julia-neme, I'll try to take a look today

@dougiesquire
Copy link
Collaborator

Okay, so again this is due to multiple things changing at the same time. The issue is not caused by the use of the intake catalog. Basically, the new experiment used in this PR has only monthly temp, whereas the original (cosima-cookbook) notebook uses yearly data. In addition, for some reason the notebook here has been changed to calculate and load x_arith_mean over all time, whereas the original notebook only loads a single year. Trying to do the same thing with the cosima-cookbook gives the same issues with the same chunking and cluster.

I'll push changes to this PR to align it with what is done in the original notebook. Note, I have to switch to the experiment 025deg_jra55_ryf9091_gadi since the notebook requires dzt which is not saved in the 025deg_jra55_iaf_omip2_cycle2 experiment currently used.

I haven't really looked into the methods at all, so it would good if someone else could review.

@julia-neme
Copy link
Collaborator

Oh ok, thanks Dougie. When I was reviewing this notebook I assumed the change in experiment was because intake didn't host the OG experiment used in the cookbook, but I must admit I didn't check. I just trusted the notebook. I'll keep these checks in mind for the rest of my reviews! I am very sorry for the false alarm.

@dougiesquire
Copy link
Collaborator

No worries @julia-neme. Please keep pinging me with issues. I'm very happy to take a look, it just might take me a few days to find time 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants