-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intake conversion True_Zonal_Mean #373
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ipes into INTAKE_True_Zonal_Mean
Ups, I've deleted my comment trying to edit it. This is a good example of not being able to use |
Thanks @julia-neme, I'll try to take a look today |
Okay, so again this is due to multiple things changing at the same time. The issue is not caused by the use of the intake catalog. Basically, the new experiment used in this PR has only monthly I'll push changes to this PR to align it with what is done in the original notebook. Note, I have to switch to the experiment I haven't really looked into the methods at all, so it would good if someone else could review. |
Oh ok, thanks Dougie. When I was reviewing this notebook I assumed the change in experiment was because intake didn't host the OG experiment used in the cookbook, but I must admit I didn't check. I just trusted the notebook. I'll keep these checks in mind for the rest of my reviews! I am very sorry for the false alarm. |
No worries @julia-neme. Please keep pinging me with issues. I'm very happy to take a look, it just might take me a few days to find time 🙂 |
Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.
A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.