-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "Use QCommandLineParser instead of custom cmd args parsing (#543)" #566
Conversation
)" This reverts commit 3e370ec. Signed-off-by: Viktor Kopp <[email protected]>
@vifactor I will test the version |
I have tried a first use case, which did not work: |
from the path I conclude that it is on Windows. Thanks @alexmucde ,I'll investigate from here |
@vifactor I will try again. |
No it works also on my side. Do not know what i made wrong last time. I will test now further use cases. |
The use cases i have tested work now. Should we give it another try now and merge it? |
I would give it a try, yes. Quite confident thanks of unit tests, but of course platform-specific bugs are not excluded, so if there is an issue would be nice to have a nice bug report |
@vifactor Tested it now also in my productive system in Ubuntu 24.04 and works fine. |
PR employs QCommandLineParser for parsing cmd args for dlt-viewer. As requested, in a followup PRs similar change can be applied to other cli tools developed in this repo.
The PR restores the previously reverted changes, that reported to cause some issues. Should remain unmerged until fix is found (but only after clear issue is reported) or we can merge it again and if issue is observed, request to create a bug ticket with clear description.
@alexmucde I would need your help to understand what kind of issues this causes and how to reproduce it. Unit tests can help to ensure workability of different cmd scenarious.