Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpM notes my version #35

Open
wants to merge 9 commits into
base: HiroshiMethod
Choose a base branch
from
Open

Conversation

tianranc
Copy link
Collaborator

@tianranc tianranc commented Sep 5, 2017

I'm creating a new version of SpM notes to change some of the notations (to match the variables used in the code) and to relabel some of the sections. This new version is still in working progress.

The original version is kept.

@tianranc tianranc requested a review from egull September 5, 2017 03:46
Copy link
Contributor

@egull egull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good! Do you want to keep the section 4 on modification for a norm constraint or just delete it? We don't use it...

@tianranc
Copy link
Collaborator Author

tianranc commented Sep 6, 2017 via email

@egull
Copy link
Contributor

egull commented Sep 11, 2017

Would you like me to merge it or do you want to keep working on it?

@tianranc
Copy link
Collaborator Author

tianranc commented Sep 11, 2017 via email

@tianranc
Copy link
Collaborator Author

Emanuel,

I tried to cherry-pick another earlier commit 7cae056, but it says there's a conflict:
src/SpM_simulation.cpp, where the conflict lies in the iteration number of simulation. I'm not quite sure how the conflict occurs? The only thing I found is that the iteration number in my commit 7cae056 is different than your commit c81bf6f. Is that how this conflict happens?

But when I look at the command lines to resolve conflicts, I'm confused:
git checkout -b tianranc-HiroshiMethod HiroshiMethod
git pull https://github.com/tianranc/Maxent.git HiroshiMethod
git checkout HiroshiMethod
git merge --no-ff tianranc-HiroshiMethod
git push origin HiroshiMethod

Are those bold HiroshiMethod from upstream or my own forked repo? If from my forked repo, then it just creates a new branch with the latest HiroshiMethod from my forked repo, merges the new branch into old local HiroshiMethod and finally updates remote HirsohiMethod in my forked repo. How does this resolve the conflict? I guess this goes back to my question of the conflict is between which and which?

Tianran

@tianranc
Copy link
Collaborator Author

Sorry, I accidentally bolded all the HirsohiMethod. The one I have question about is the first: is it from upstream or my forked repo?

git checkout -b tianranc-HiroshiMethod HiroshiMethod
git pull https://github.com/tianranc/Maxent.git HiroshiMethod
git checkout HiroshiMethod
git merge --no-ff tianranc-HiroshiMethod
git push origin HiroshiMethod

@tianranc
Copy link
Collaborator Author

Problem solved. I just created a new pull request#45, with the commit I'd like to merge. Please ignore my two messages this morning as well this old pull request#35.

@egull
Copy link
Contributor

egull commented Jul 25, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants