Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KP-8261 Fixes required before going to production #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

KP-8261 Fixes required before going to production #27

wants to merge 4 commits into from

Conversation

aajarven
Copy link
Member

@aajarven aajarven commented Jan 30, 2025 •
edited
Loading

Fixed issues / improvements:

  1. Metax defaults to everything being unpublished, meaning that the records are not viewable without the creator's API token. We want ours to be public.
  2. Fairdata services expect persistent identifiers (preferred identifiers in old API vocabulary) to not have the urn.fi part (see e.g. metax v1 search results in our catalogue), and we need to comply with that to be able to identify records when updating from old harvests.
  3. Option to run the bridge one record at a time: this allows us to verify a couple of records exported to production before overwriting everything.
  4. Remove unnecessary restriction grounds logic for ACA + availableUnrestrictedUse (does not occur in our metadata, nor should it occur in the future)

@aajarven aajarven force-pushed the KP-8261 branch 4 times, most recently from 03b61be to 1bc86c1 Compare February 5, 2025 11:19
@aajarven
KP-8261 Set datasets to published in Metax
aff9bc8 
Metax defaults to everything being unpublished, meaning that the records
are not viewable without the creator's API token. We want ours to be
public.
@aajarven
KP-8261 Drop urn.fi from persistent identifiers uploaded to Metax
c469a0a 
Fairdata services seem to expect only the urn:nbn:fi:lb-01234 part as
persistent_identifier (or preferred_identifier in older API versions).
Failure to comply with this expectation leads both to the identifier
field in Etsin not functioning as a clickable button and our records
from this new bridge and the old harvests by Metax team not matching up,
resulting in double entries for each dataset if not fixed.
@aajarven aajarven changed the title KP-8261 Set datasets to published in Metax KP-8261 Fixes required before going to production Feb 7, 2025
@aajarven
KP-8261 Add option to run harvest and upload one record at a time
46da34c 
This is useful when doing the final confirmations that the tool works
against the production environment: this way we hopefully don't
overwrite the whole catalogue before noticing systematic problems.
@aajarven
KP-8261 Remove unnecessary restriction grounds emptying
573357e 
This should never trigger, nor does it with our current data set. Adding
it in was likely based on false information arising from a bug that made
it look like ACA corpora could have access type open in Comedi (they
shouldn't).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aajarven