Skip to content

Commit

Permalink
Update env vars to building configs
Browse files Browse the repository at this point in the history
Change MONGO_SSL env var to false and update docker-compose
Update default metax url if one is not found
Update github workflow file
  • Loading branch information
genie9 committed Feb 28, 2022
1 parent 2a06c6a commit 84dc388
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ MONGO_DATABASE=default
MONGO_AUTHDB=admin
MONGO_INITDB_ROOT_PASSWORD=admin
MONGO_INITDB_ROOT_USERNAME=admin
MONGO_SSL=true
MONGO_SSL=false
MONGO_SSL_CA=/tls/cacert
MONGO_SSL_CLIENT_KEY=/tls/key
MONGO_SSL_CLIENT_CERT=/tls/cert
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/int.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ jobs:
env:
BASE_URL: http://localhost:5430
OIDC_URL: http://localhost:8000
MONGO_HOST: localhost:27017
MONGO_DATABASE: default
MONGO_AUTHDB: admin


- name: Collect logs from docker
if: ${{ failure() }}
run: docker-compose logs --no-color -t > tests/dockerlogs || true
Expand Down Expand Up @@ -78,7 +75,8 @@ jobs:
MONGO_HOST: localhost:27017
MONGO_DATABASE: default
MONGO_AUTHDB: admin

MONGO_SSL: True

- name: Run Integration test
run: |
python tests/integration/run_tests.py
Expand Down
7 changes: 6 additions & 1 deletion docker-compose-tls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ services:
build:
dockerfile: Dockerfile-dev
context: .
target: develop
image: cscfi/metadata-submitter-dev
container_name: "metadata_submitter_backend_dev"
volumes:
Expand All @@ -14,6 +15,7 @@ services:
- database
- mockauth
- mockdoi
- mockmetax
restart: on-failure
environment:
- "MONGO_HOST=${MONGO_HOST}"
Expand Down Expand Up @@ -57,6 +59,7 @@ services:
build:
dockerfile: Dockerfile-dev
context: .
target: develop
image: cscfi/metadata-submitter-dev
environment:
- "LOG_LEVEL=${LOG_LEVEL}"
Expand All @@ -74,6 +77,7 @@ services:
build:
dockerfile: Dockerfile-dev
context: .
target: develop
image: cscfi/metadata-submitter-dev
hostname: mockdoi
expose:
Expand All @@ -87,6 +91,7 @@ services:
build:
dockerfile: Dockerfile-dev
context: .
target: develop
image: cscfi/metadata-submitter-dev
hostname: mockmetax
expose:
Expand All @@ -97,4 +102,4 @@ services:
- ./tests/integration/mock_metax_api.py:/mock_metax_api.py
entrypoint: ["python", "/mock_metax_api.py", "0.0.0.0", "8002"]
volumes:
data:
data:
6 changes: 4 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ services:
- database
- mockauth
- mockdoi
- mockmetax
restart: on-failure
environment:
- "MONGO_HOST=${MONGO_HOST}"
Expand Down Expand Up @@ -63,7 +64,7 @@ services:
- 8000:8000
volumes:
- ./tests/integration/mock_auth.py:/mock_auth.py
entrypoint: [ "python", "/mock_auth.py", "0.0.0.0", "8000" ]
entrypoint: ["python", "/mock_auth.py", "0.0.0.0", "8000"]
mockdoi:
build:
dockerfile: Dockerfile-dev
Expand All @@ -77,11 +78,12 @@ services:
- 8001:8001
volumes:
- ./tests/integration/mock_doi_api.py:/mock_doi_api.py
entrypoint: [ "python", "/mock_doi_api.py", "0.0.0.0", "8001" ]
entrypoint: ["python", "/mock_doi_api.py", "0.0.0.0", "8001"]
mockmetax:
build:
dockerfile: Dockerfile-dev
context: .
target: develop
image: cscfi/metadata-submitter-dev
hostname: mockmetax
expose:
Expand Down
2 changes: 1 addition & 1 deletion metadata_backend/api/metax_api_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __init__(self, req: Request) -> None:

self.username = os.getenv("METAX_USER", "sd")
self.password = os.getenv("METAX_PASS", "test")
self.metax_url = os.getenv("METAX_URL", "http://mockmetax:8002")
self.metax_url = os.getenv("METAX_URL", "http://localhost:8002")
self.rest_route = "/rest/v2/datasets"
self.publish_route = "/rpc/v2/datasets/publish_dataset"

Expand Down
2 changes: 1 addition & 1 deletion tests/integration/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
users_url = f"{base_url}/users"
submit_url = f"{base_url}/submit"
publish_url = f"{base_url}/publish"
metax_url = "http://mockmetax:8002/rest/v2/datasets"
metax_url = f"{os.getenv('METAX_URL', 'http://localhost:8002')}/rest/v2/datasets"
# to form direct contact to db with create_folder()
DATABASE = os.getenv("MONGO_DATABASE", "default")
AUTHDB = os.getenv("MONGO_AUTHDB", "admin")
Expand Down

0 comments on commit 84dc388

Please sign in to comment.