Floodnet contribution #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Martin, thanks very much! |
Minor bug on FitRoi and predict.reglmom
* Improve speed of FitAmax when estimating covariance matrix using L-moments * Modify default boot option to 500 * Add fgam,fgum and fnor. * Make FitPot bootstrap parametric. * Add balanced bootstrap for Amax * Correct documentations * Improve the choice of starting solutions for f-function (e.g. fgev).
* Correct bugs with predictions using reglmom and POT. Bootstrap correctly done using 2 parameter GPA. See subfunction .SimulatePotQ. Correct that part in the vignette.
+ bug in predict.amax
|
Hi Martin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my work in FloodNet I have developed several functions to perform flood frequency analysis. They aim to facilitate both at-site and regional frequency analysis using either annual maxima or peaks over threshold following an S3 paradigm. It most likely need some more improvements and changes to before being fully compliant with the package guidelines. I would like to know if this is of interest to you and if there are major changes that need to be done.