Valgrind issues

[mdunphy]

Generic Issue

• Raven version: 3.8
• Operating System: Ubuntu 22.04

Description

In an effort to solve issue #31, I ran the test case under valgrind to look for memory errors, and then solved /some/ of the reports. This effort did not solve #31, but having solved a few of the valgrind reports, it seems worthwhile to send the fixes here

1. g.alb_decay_melt not initialized, looks like a copy-paste oversight, second line here should initialize g.alb_decay_melt

RavenHydroFramework/src/GlobalParams.cpp

Lines 406 to 407 in 37b761b

	g.alb_decay_cold =DefaultParameterValue(is_template,true);
	g.alb_decay_cold =DefaultParameterValue(is_template,true);

2. This object p is not freed at the end of the function (minor one-time memory leak):

RavenHydroFramework/src/ParsePropertyFile.cpp

Line 245 in 37b761b

CParser *p=new CParser(INPUT,Options.rvp_filename,line);

3. This also looks like a typo, should check aPCm on second line:

RavenHydroFramework/src/ParsePropertyFile.cpp

Lines 1701 to 1702 in 37b761b

	if (aPm!=NULL){delete [] aPm; aPm=NULL;}
	if (aPm!=NULL){delete [] aPCm;aPCm=NULL;}

I think these are trivial issues -- and the main benefit of fixing them is to have fewer valgrind reports to dig through in future debugging

PR forthcoming