Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three minor issues flagged by valgrind #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdunphy
Copy link

@mdunphy mdunphy commented Oct 17, 2024

  • Initialize g.alb_decay_melt in CGlobalParams::InitializeGlobalParameters
  • Free p in ParseClassPropertiesFile
  • Fix free in AddToMasterParamList

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Fixes the issues described in #48

Does this PR introduce a breaking change?

No

Other information:

N/A

* Fix free in AddToMasterParamList
* Free p in ParseClassPropertiesFile
* Initialize g.alb_decay_melt in CGlobalParams::InitializeGlobalParameters
Copy link

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.md and .zenodo.json:

  • The relevant author information has been added to AUTHORS.md and .zenodo.json

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valgrind issues
1 participant