Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #400

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Build fixes #400

merged 5 commits into from
Sep 30, 2024

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Sep 30, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Adds setuptools to the build recipe
  • Fixes the trigger for the scorecard workflow

Does this PR introduce a breaking change?

No.

Other information:

Due to the fact that several different options exist for build backends, setuptools is no longer installed by default in newer versions of Python (3.12+).

@Zeitsperre Zeitsperre self-assigned this Sep 30, 2024
@github-actions github-actions bot added the CI label Sep 30, 2024
@github-actions github-actions bot added the docs label Sep 30, 2024
Copy link
Collaborator

@lou-a lou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nothing to change.

@Zeitsperre Zeitsperre merged commit 4fe8045 into master Sep 30, 2024
17 checks passed
@Zeitsperre Zeitsperre deleted the build-fixes branch September 30, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants