Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter, mark dead code #444

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update cookiecutter, mark dead code #444

merged 3 commits into from
Jan 24, 2025

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jan 23, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the cookiecutter template to the latest commit
  • The CodeQL configuration has been replaced with a newer base template
  • Adds two new hooks to pre-commit:
    • vulture: for finding dead code blocks
    • zizmor: for finding insecure workflow configurations

Does this PR introduce a breaking change?

No. Function call signatures have not been changed.

Other information:

Lots of a FIXME notices have been added for unused call signature variables. These should be addressed in the next major release.

mypy is staged, but the code base is far from being able to adopt it. We need to address a lot of typing issues.

I think we can safely tag a new version after this PR is merged.

@Zeitsperre Zeitsperre requested review from huard and tlvu January 23, 2025 21:55
@Zeitsperre Zeitsperre self-assigned this Jan 23, 2025
@coveralls
Copy link

coveralls commented Jan 23, 2025

Coverage Status

coverage: 81.288% (-0.004%) from 81.292%
when pulling b905fa7 on cruft
into a307918 on master.

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Trevor James Smith <[email protected]>
@Zeitsperre Zeitsperre merged commit ade0622 into master Jan 24, 2025
13 checks passed
@Zeitsperre Zeitsperre deleted the cruft branch January 24, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants