-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added next and anonymize in requirements #169
base: master
Are you sure you want to change the base?
Conversation
- Added support for anonymize flag in requirements - Added data in flags with static type in challenge-example.yml to avoid verify command fails - Added sort for requirements because it seems CTFd does not accept prerequisites if they are not sorted. - Applied black to challenge.py to avoid Linting error.
I'm not sure if the anonymize feature should be shown as require_anonymize. Could it possibly be a sub section of requirements? It would be better if next_id was just |
Of course, I know anonymize should be under requirements. But I didn't do that because the change will break the current format of challenge.yml. We could not reuse challenges created in the past if the change was applied. I want to avoid that.
I chose next_id because CTFd uses the name. But it is OK to change. |
I changed next_id to next. |
I omit anonymize_require and ctfcli now accepts both styles like below and anonymize flag is a sub section of requirements.
|
I will try to update to the v4 upload action. Last time I tried it, I failed at migrating away from v3 but maybe it got better. |
I bet it's successful! |
I think you already know, but just in case..., You might pay attention to this. https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
It seems you have already used ctfcli-0.1.3.tar.gz. So you might need to bump the version number to 0.1.4 or something like that. |
No description provided.