Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various TDA19988 fixes #1821

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Various TDA19988 fixes #1821

merged 4 commits into from
Sep 5, 2023

Conversation

jrtc27
Copy link
Member

@jrtc27 jrtc27 commented Aug 29, 2023

  • tda19988: Implement a non-stub mode_valid to filter unsupported resolutions
  • tda19988: Properly implement mode_set/bridge_enable/bridge_disable flow
  • tda19988: Fix divisor calculation
  • komeda: Drop temporary resolution hack

jrtc27 and others added 4 commits August 29, 2023 21:35
@jrtc27
tda19988: Implement a non-stub mode_valid to filter unsupported resol…
a2bbba0 
…utions
@jrtc27 @bukinr
tda19988: Properly implement mode_set/bridge_enable/bridge_disable flow
e227dac 
Otherwise, when SDDM tries to put the display to sleep, we don't disable
the output and end up outputting a garbled picture, where the amount of
garbling increases with system activity.

Co-authored-by: Ruslan Bukin <[email protected]>
@jrtc27
tda19988: Fix divisor calculation
d7c2cf6 
The existing calculation was linear with a fixup to make it non-linear
(and, correctly, cap it at 3). However, the actual value is logarithmic
and this ended up generating bad values in the following ranges:

* [20000, 37125] - gave a divisor of 3 not 2
* [40000, 49500] - gave a divisor of 2 not 1
* [74251, 79999] - gave a divisor of 0 not 1
@jrtc27
komeda: Drop temporary resolution hack
068b1e9 
This was presumably an attempt to work around not having properly
implemented mode_valid in the tda19988 driver.
bsdjhb
bsdjhb reviewed Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@bsdjhb bsdjhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this does allow my monitor to go to sleep at sddm.

bsdjhb
bsdjhb reviewed Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@bsdjhb bsdjhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this supplants #1618 btw since the second commit here is a squash of that?

@jrtc27
Copy link
Member Author

jrtc27 commented Aug 29, 2023 •
edited
Loading

I assume this supplants #1618 btw since the second commit here is a squash of that?

Partially. This doesn't change anything for komeda. And I wrote it from scratch (other than the enable / disable bits, which is what the Co-authored-by is for), so it's slightly different (e.g. mode vs adjusted_mode).

kwitaszczyk
kwitaszczyk approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@kwitaszczyk kwitaszczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this patch works correctly on my screen - ASUS ProArt Display PA148CTV. Instead of displaying garbage, the screen sleeps due to inactivity in sddm.

@jrtc27 jrtc27 mentioned this pull request Aug 31, 2023
Open
@bsdjhb bsdjhb merged commit a47d2fe into dev Sep 5, 2023
26 of 27 checks passed
@bsdjhb bsdjhb deleted the tda19988-fixes branch September 5, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsdjhb bsdjhb bsdjhb left review comments

@kwitaszczyk kwitaszczyk kwitaszczyk approved these changes

@arichardson arichardson Awaiting requested review from arichardson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrtc27 @bsdjhb @kwitaszczyk