morello: Disable libssl ASM optimisation in the base system. #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hybrid ABI libssl uses optimised assembly implementations for crypto functions. This is a problem for benchmarks because we don't currently have pure-capability variants of these functions. This patch temporarily disables ASM optimisations on AArch64, so that we maintain the same behaviour on all ABIs.
|
This should not be merged IMO, just as we still use optimised string routines for aarch64 where possible |
|
I'm fine with not merging, but I'm worried about caveats for benchmarking that may bite us multiple times and should probably be documented somewhere. |
|
Looks like #2120 supersedes this, but I'm leaving it open as that PR isn't quite done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hybrid ABI libssl uses optimised assembly implementations for crypto functions. This is a problem for benchmarks because we don't currently have pure-capability variants of these functions. This patch temporarily disables ASM optimisations on AArch64, so that we maintain the same behaviour on all ABIs.