Implement getUserProfile grpc #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitiwat-owen
requested changes
Nov 8, 2023
src/proto/user.proto
Outdated
Comment on lines
20
to
22
| string access_token = 1; | ||
| } |
There was a problem hiding this comment.
Why don't we use user_id instead of access_token since we already have it on gateway
src/user/user.service.ts
Outdated
Comment on lines
106
to
135
| public async getUserProfile(request: GetUserProfileRequest): Promise<GetUserProfileResponse> { | ||
| try { | ||
|
|
||
| let credential = this.jwtService.decode( | ||
| request.accessToken, | ||
| ) as JwtPayload; | ||
| let userId = credential.sub; | ||
| let user = await this.userRepo.findUserById(userId); | ||
| let userSportArea = await this.sportAreaListRepo.findSportAreaOfUser(userId) | ||
| return { | ||
| id: user.id, | ||
| firstName: user.firstName, | ||
| lastName: user.lastName, | ||
| email: user.email, | ||
| photoURL: user.photoURL, | ||
| role: user.role, | ||
| sportAreaId: ((userSportArea == null) ? null : userSportArea.SportAreaId), | ||
| } | ||
|
|
||
| } catch (err: any) { | ||
| console.log(err); | ||
| if (!(err instanceof RpcException)) { | ||
| throw new RpcException({ | ||
| code: status.INTERNAL, | ||
| message: 'internal server error cant get user profile', | ||
| }); | ||
| } | ||
| throw err; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you need to call fileService to retrieve profileUrl
Arnan-Dee
force-pushed
the
feature/SPGO-105
branch
from
6dc8a0d to
761a298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how to invoke a gRPC method to getUserProfile
This is gRPC request/response look like