Implemented simulation an arbritrary number of scalars. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-costa
force-pushed
the
multiple-scalars
branch
7 times, most recently
from
ce28f81 to
1263fa1
Compare
p-costa
force-pushed
the
multiple-scalars
branch
2 times, most recently
from
0ec9721 to
59da189
Compare
bahardy
reviewed
Feb 10, 2025
p-costa
force-pushed
the
multiple-scalars
branch
9 times, most recently
from
5293d81 to
151da19
Compare
This major update enables the simulation of an arbritrary number of scalars, with flexible temporal discretization of diffusion terms, developed by @bahardy. The first scalar is treated as a temperature which can optionally trigger thermal convection within the Boussinesq approximation. Documentation, tests, and examples have been updated to address this update. See the `News` section in the `README.md` file. Co-authored-by: Baptiste Hardy <[email protected]> Co-authored-by: bahardy
p-costa
force-pushed
the
multiple-scalars
branch
from
37c5d00 to
61a8425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major feature update
This major update enables the simulation of an arbitrary number of scalars, with flexible temporal discretization of diffusion terms, developed by Baptiste Hardy (@bahardy). The first scalar can be optionally treated as a temperature difference to trigger thermal convection within the Boussinesq approximation. The
main.f90file has also been simplified thanks to a wrapper subroutine for solving a Helmholtz equation by Baptiste. Documentation, tests, and examples have been extended/updated. See theNewssection in theREADME.mdfile in this PR.