QA: Porting 1.2.24 Changes back to the Develop Branch #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template Export missing Graph Template columns multiple and test_source
* On large systems statistics gathering at the beginning of a poller run lead to excessive polling times
Edit Graph Template link missing base_url
Searching for Poller Items Generates SQL Errors
When using Gradient Support GPRINT Text Format is misaligned
Device Template Filter broken
Spikekill Backtrace Argument #1 ($string) must be passed by reference, value given
Gradient support breaks certain Graphs with special characters in them
PHP Diff Renderer throws warnings
Realtime graph on remote poller not working in 1.2.23
When trying to obtain data, cacti should not log Transport Read errors
Cacti function throws errors when attempting to render classic images in PHP8
Minor issues in modern and dark prevent weathermaps from rendering correctly
When importing packages, Graph Size does not get updated to Graph Templates
Scripts ss_net_snmp_device_io.php and ss_net_snmp_device_bytes.php break when using HMIB plugin and PHP8.1
* When using Diff Viewer, rendering is not always correct under certain themes * Remove some c3.css files too
Package form objects use the wrong text domain in their i18n strings
Undefined variable $user_id when creating new graph
Compatibility improvements for Installer under PHP 8.x
Basic Auth is timing out and logging users off automatically
Basic Auth is timing out and logging users off automatically
Drop callback function sometimes puts name in the form input instead of the id
When poller runtime is exceeded, time should be display as a rounded number
When debugging a data source, errors may be shown if no RRDfile created yet
CSRF directory needs to be writeable for creating the csrf-secret.php file
"Balance Process Load" dont work after upgrade to 1.2.23
* Rebuilding Poller Cache from Utilities does not respect poller interval due to lack or ordering * Decrementing of rrd_next_step is flawed
netniV
reviewed
Feb 22, 2023
Comment on lines
+193
to
+205
| if (isset($matches[1])) { | ||
| $spaces = $matches[1]; | ||
|
|
||
| if ($spaces != '') { | ||
| $count = strlen($spaces); | ||
|
|
||
| if ($count == 0) { | ||
| return ''; | ||
| } | ||
| } else { | ||
| return ''; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
This change should be reported upstream.
There was a problem hiding this comment.
I did report it upstream and it looks like the maintainer is not merging much.
Issue reported here:
Pull request here (unmerged, with interesting feedback).
There was a problem hiding this comment.
Recommended replacement. Uses namespaces.
There was a problem hiding this comment.
The Horde is dead too or so it would appear and not issue tracker. So, not a well oiled machine. I suggest we switch to jfcherng in 1.3 and drop the other two.
There was a problem hiding this comment.
Sounds like a plan as long as it's not too slow
Porting two issues identified in testing from the 1.2.x branch - Force active profiles to > 1 for cases where max_step does not equal the poller interval - Set the legacy value of poller_lastrun for other uses in Cacti.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes porting of several 1.2.24 bug fixes to the
developbranch. Those fixes include at total of 25 bugs and 28 commits. Issues include:#5239, #5243, #5232, #5236, #5238, #5190, #5188, #5195, #5196, #5198, #5199, #5200, #5201, #5202, #5203, #5204, #5205, #5208, #5211, #5207, #5214, #5223, #5224, #5227, #5194
Plus two additional minor fixes that did not receive a CHANGELOG entry