Fix cli scripts #5729
Merged
Fix cli scripts #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix incorrect variable
|
Found more.... wait with approve |
|
done |
TheWitness
pushed a commit
that referenced
this pull request
Apr 15, 2024
* fix php8 issue - int vs. string compare fix incorrect variable * incorrect variable name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script change_device.php has error:
PHP Warning: Undefined array key "ip" in /usr/local/share/cacti_develop/cli/change_device.php on line 370
In scripts is used variable $ip instead of $hostname. I don't want to change it. So only small fix.
Script add_device.php - PHP 8 issue. Without define --template=X is $template_id defaulted from settings and it could be string(0) ""
It is incorrect compare here:
if (!isset($host_templates[$template_id])) {
}
ERROR: Unknown template id ()
array(2) {
[0]=>
string(4) "None"
[1]=>
string(19) "Generic SNMP Device"