cancel zoom refactoring #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenik72
reviewed
Mar 19, 2024
.eslintrc.json
Outdated
| "promise" | ||
| ], | ||
| "rules": { | ||
| "react/jsx-closing-bracket-location": "off", |
There was a problem hiding this comment.
У тебя же онли джиес. Правила для jsx тут вообще лишние.
.eslintrc.json
Outdated
| }, | ||
| "extends": [ | ||
| "umbrellio", | ||
| "plugin:promise/recommended" |
| @@ -3,6 +3,7 @@ | |||
| "version": "1.0.0", | |||
| "description": "Cancelling auto zoom on mobile devices", | |||
| "main": "cancelAutoZoomInput.js", | |||
| "prepublishOnly": "yarn build", | |||
package.json
Outdated
| "eslint-config-umbrellio": "^5.0.1" | ||
| }, | ||
| "dependencies": { | ||
| "eslint": "^8.57.0" |
There was a problem hiding this comment.
Можно разобраться и сделать джобу на линт
elenik72
reviewed
Mar 19, 2024
rollup.config.mjs
Outdated
| "eslint-plugin-import": "^2.29.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prefer-object-spread": "^1.2.1", | ||
| "eslint-plugin-promise": "^6.1.1", |
There was a problem hiding this comment.
а линтер ругался если я пробовал без этого запускать
.github/workflows/ci-deploy.yml
Outdated
| @@ -3,15 +3,26 @@ name: deploy | |||
| on: | |||
There was a problem hiding this comment.
не, это у тебя джоба для паблиша во время релиза. А тебе нужно отдельная джоба для линта, которая будет запускаться на ПР и коммитах. Это отдельно нужно делать в отдельном файле я б даже сделал
|
У тебя падает джоба из-за несовместимости нод версии |
added 2 commits
March 19, 2024 16:11
Ginger-nomad
force-pushed
the
refactoring
branch
from
4a2b31a to
4284b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.