Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add angle-based section visibility path occlusion #2811

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add angle-based section visibility path occlusion #2811

merged 2 commits into from
Oct 21, 2024
+32 −2

Conversation

douira
Copy link
Collaborator

@douira douira commented Oct 11, 2024

In my test scene it reduces section count from 4875 down to 4370 sections (11%), and bfs time by 13%.

@douira douira added the T-enhancement Type: Enhancement label Oct 11, 2024
jellysquid3
jellysquid3 approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@jellysquid3 jellysquid3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes as proposed look good to me. From testing, it doesn't seem to introduce any errors, but we'll do a smoke test before merging to be certain.

@jellysquid3 jellysquid3 merged commit 37dc5f6 into CaffeineMC:dev Oct 21, 2024
1 check passed
@douira douira deleted the sharp-angle-traversal-occlusion branch October 26, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellysquid3 jellysquid3 jellysquid3 approved these changes

Assignees
No one assigned
Labels
T-enhancement Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douira @jellysquid3