-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CI workflow logic #195
Conversation
Some checks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems sensible @jwallwork23
A couple of stylistic comments and a suggestion to remove the options you had already flagged.
Co-authored-by: Jack Atkinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have added suggestions for formatting of the other branch coverage lists.
Co-authored-by: Jack Atkinson <[email protected]>
Closes #194.
In the interests of green computing and avoiding hitting the limit of the free-plan, this PR introduces some logic to only run workflows if relevant changes are made.
CMakeLists.txt
,requirements.txt
, or data are changed.pages/
have changed.If any of the workflow files are changed then those tests should also be run.
The PR also improves the consistency of formatting across the workflow configuration files.