Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_device_index method in test #267

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Jan 30, 2025

Looks like I failed to re-test later changes in #222.

Building with CUDA support I got

/home/joewa/software/FTorch/src/build/test/unit/test_tensor_interrogation_cuda.F90:64:19:

   64 |     if (expected /= torch_tensor_get_device_index(tensor)) then
      |                   1
Error: Function ‘torch_tensor_get_device_index’ at (1) has no IMPLICIT type
/home/joewa/software/FTorch/src/build/test/unit/test_tensor_interrogation_cuda.F90:77:8:

   77 |    use test_tensor_interrogation_cuda
      |        1
Fatal Error: Cannot open module file ‘test_tensor_interrogation_cuda.mod’ for reading at (1): No such file or directory
compilation terminated.

which is fixed here.

@jwallwork23 jwallwork23 added the bug Something isn't working label Jan 30, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 30, 2025
Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwallwork23

Another good reason for getting a GPU runner going on occasion - @dorchard

jwallwork23 added a commit that referenced this pull request Jan 30, 2025
@jwallwork23 jwallwork23 merged commit 46dfa7e into main Jan 30, 2025
5 checks passed
@jwallwork23 jwallwork23 deleted the hotfix-cuda-device-index-test branch January 30, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants