Python translation of fcDatetick (plus some extra testing for datenum and a fix) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorchard
changed the title
|
All tests pass, I pushed a fix to the overwritten site data and removed a typo which caused the test to fail. I think it's good to merge |
j-emberton
approved these changes
Jan 27, 2025
| @@ -1,6 +1,6 @@ | |||
| import numpy | |||
| from fcDatevec import mydatevec | |||
| from fcDatenum import mydatenum | |||
| from fcDatenum import datenum | |||
|
|
|||
| def mydoy(t): | |||
|
Added the type hints now and also made a change to the test to remove a latent use of explicit matlab engine @j-emberton |
j-emberton
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is mostly a debugging plotting routine and its tests are largely a smoke test over various options so it's relatively low priority in terms of its exact matching MATLAB. After discussion with Gilberto we decided we don't really need it.
Along the way I discovered though that our implementation of
datenumneeds improving and so this PR also adds separate tests for this function and some updates