Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fcNaniqr #71

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Test fcNaniqr #71

merged 4 commits into from
Dec 13, 2024

Conversation

j-emberton
Copy link
Member

@j-emberton j-emberton commented Dec 10, 2024

closes #69

This PR adds tests for fcNaniqr.m. Along the way two bugs have been found which are documented in issue #70.

The purpose of this function is to find the iqr (inter quartile range) of data in array columns. The arrays may be 1D, 2D or 3D. Each case has its own tests. The function returns the IQR for each column as a double, or array of doubles.

The original function has had some minor refactoring for legibility. The tests capture the original functionality bugs and all.

All tests pass.

@j-emberton j-emberton self-assigned this Dec 10, 2024
@j-emberton j-emberton marked this pull request as ready for review December 10, 2024 12:00
Copy link
Member

@dorchard dorchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@isaacaka isaacaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - added comments on tests for different column lengths

@dorchard dorchard merged commit 3e880a4 into ustar_cp_refactor_main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants