Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wren-ui): sql server ssl property default value replace with initial value #1338

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

andreashimin
Copy link
Contributor

@andreashimin andreashimin commented Feb 25, 2025

Description

This PR fixes the issue where the default value of SQL Server SSL properties does not work because Antd Form treats initialValue as the actual value.

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the default behavior of the "Enable Trust Server Certificate" option so it now initializes as enabled consistently, ensuring that the toggle accurately reflects its intended starting state for a clearer user experience.

@andreashimin andreashimin added the module/ui UI related label Feb 25, 2025
Copy link
Contributor

coderabbitai bot commented Feb 25, 2025

Walkthrough

The update modifies the SQLServerProperties component used in setting up SQL Server data sources. The form field for "Enable Trust Server Certificate" now sets its initial state using the initialValue property set to true. The removal of the defaultChecked prop from the Switch component ensures that the component no longer visually represents a default checked state, instead relying solely on the form's initial state. There are no changes to exported or public entity declarations.

Changes

File Summary
wren-ui/src/components/pages/setup/dataSources/SQLServerProperties.tsx Modified the "Enable Trust Server Certificate" form item by adding initialValue: true and removing the defaultChecked prop from the Switch.

Suggested reviewers

  • fredalai

Poem

I hopped to the code with glee,
Tweaking settings, one, two, three.
Trust is now set to true,
Old defaults bid adieu,
Let’s hop into a bug-free spree! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c79c98 and 98dfeeb.

📒 Files selected for processing (1)
  • wren-ui/src/components/pages/setup/dataSources/SQLServerProperties.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
wren-ui/src/components/pages/setup/dataSources/SQLServerProperties.tsx (1)

97-99: Correctly fixed form initialization issue.

The change appropriately addresses the form initialization issue by:

  1. Adding initialValue={true} to the Form.Item to set the initial form state
  2. Removing the defaultChecked prop from the Switch component

This fix resolves the conflict between Ant Design's form control system and the direct component state control. Using initialValue ensures the form properly tracks the value throughout its lifecycle, while removing defaultChecked prevents potential conflicts between form-controlled and component-controlled states.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this issue.

@andreashimin andreashimin merged commit e901342 into main Feb 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ui UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants