Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crossterm to 0.27.0 and bump minor version #17

Closed
wants to merge 1 commit into from

Conversation

andrewtc
Copy link

@andrewtc andrewtc commented Jan 6, 2024

Hello! I am currently developing a CLI app in my spare time using termimad. Long story short, I needed to update to the very latest version of crossterm so that I can suppress color output based on a command line argument. There were some breaking changes to the public interface in the latest version of crossterm (0.27.0), so I had to make edits to all of the following libraries locally in order to get everything to work:

termimad

Please see this MR

  • Bumped crossterm version to 0.27.0 from =0.23.2
  • Some places where KeyEvent was being initialized needed to be updated to initialize new members kind and state
  • Added underline_color to CompoundStyle
  • Increased crate version to 0.27.0 from 0.26.1

crokey

  • Bumped crossterm version to 0.27.0 from 0.24.0
  • Needed to make similar edits to a couple functions and the key! macro to initialize new KeyEvent members
  • Increased crate version to 0.6.0 from 0.5.1

coolor

Please see this MR

  • Bumped crossterm version to >=0.23.2 from =0.23.2 to resolve a compile error caused by mismatched crossterm versions
  • Increased crate version to 0.8.1 from 0.8.0, since (AFAIK) this shouldn't be a breaking change

I ran tests and examples to ensure that everything was working as best I could. However, I would appreciate if you would give the changes a once-over and just verify that I haven't missed any broken behavior. Please note that I am developing on Windows and that I have very limited ability to test cross-platform. If you have a standard way of verifying these changes on Mac and Linux, please let me know if there is a way that I can help. Thank you!

@Canop
Copy link
Owner

Canop commented Jan 12, 2024

Thanks. But I was working on a bigger PR also bringing crossterm to 0.27: #18

So closing this PR

@Canop Canop closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants