Skip to content

Commit

Permalink
fix the audio bugs (#279)
Browse files Browse the repository at this point in the history
* fix the audio bugs

* remove unnecessary stuff

* more

* handle stereo recording

* audio is so back baby

* cap apps -> integrations

* fix audio encoder heading
Brendonovich authored Jan 30, 2025
1 parent e84ca78 commit 2d290ff
Showing 23 changed files with 867 additions and 748 deletions.
10 changes: 9 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ anyhow = "1.0.86"
# This includes a currently-unreleased fix that ensures the audio stream is actually
# stopped and released on drop on macOS
cpal = { git = "https://github.com/RustAudio/cpal", rev = "f43d36e55494993bbbde3299af0c53e5cdf4d4cf" }
ffmpeg = { package = "ffmpeg-next", git = "https://github.com/CapSoftware/rust-ffmpeg", rev = "91b29d09a8c7cb4f5659c38f1f0924b980a30cba" }
ffmpeg = { package = "ffmpeg-next", git = "https://github.com/CapSoftware/rust-ffmpeg", rev = "29433c248bcd" }
ffmpeg-sys-next = "7.1.0"
tokio = { version = "1.39.3", features = [
"macros",
18 changes: 0 additions & 18 deletions apps/desktop/src/routes/(window-chrome)/(main).tsx
Original file line number Diff line number Diff line change
@@ -186,24 +186,6 @@ export default function () {
</ErrorBoundary>
</div>
<div class="flex items-center space-x-2">
<Tooltip.Root openDelay={0}>
<Tooltip.Trigger>
<button
type="button"
onClick={() =>
commands.showWindow({ Settings: { page: "apps" } })
}
>
<IconLucideLayoutGrid class="w-[1.25rem] h-[1.25rem] text-gray-400 hover:text-gray-500" />
</button>
</Tooltip.Trigger>
<Tooltip.Portal>
<Tooltip.Content class="z-50 px-2 py-1 text-xs text-gray-50 bg-[--gray-500] rounded shadow-lg animate-in fade-in duration-100">
Cap Apps
<Tooltip.Arrow class="fill-[--gray-500]" />
</Tooltip.Content>
</Tooltip.Portal>
</Tooltip.Root>
<Tooltip.Root openDelay={0}>
<Tooltip.Trigger>
<button
6 changes: 3 additions & 3 deletions apps/desktop/src/routes/(window-chrome)/settings.tsx
Original file line number Diff line number Diff line change
@@ -43,9 +43,9 @@ export default function Settings(props: RouteSectionProps) {
icon: IconLucideCamera,
},
{
href: "apps",
name: "Cap Apps",
icon: IconLucideLayoutGrid,
href: "integrations",
name: "Integrations",
icon: IconLucideUnplug,
},
{
href: "feedback",
8 changes: 8 additions & 0 deletions crates/audio/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[package]
name = "cap-audio"
version = "0.1.0"
edition = "2021"

[dependencies]
ffmpeg = { workspace = true }
cpal = { workspace = true }
1 change: 1 addition & 0 deletions crates/audio/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
just a testing ground for audio stuff
Loading

1 comment on commit 2d290ff

@vercel
Copy link

@vercel vercel bot commented on 2d290ff Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.