Add update_reserved_value method to Mint module and tests #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekkac
previously approved these changes
Mar 18, 2024
src/components/mint/interface.cairo
Outdated
| @@ -28,6 +28,7 @@ trait IMint<TContractState> { | |||
| fn set_min_value_per_tx(ref self: TContractState, min_value_per_tx: u256); | |||
| fn set_max_value(ref self: TContractState, max_value: u256); | |||
| fn set_unit_price(ref self: TContractState, unit_price: u256); | |||
| fn update_reserved_value(ref self: TContractState, value: u256); | |||
| fn decrease_reserved_value(ref self: TContractState, value: u256); | |||
There was a problem hiding this comment.
update vs decrease:
- should we remove decrease_reserved_value or,
- should we rename to inrease_reserved_value ?
There was a problem hiding this comment.
in this case, we should remove decrease.
tekkac
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #339