New Staking Curve #113
Open
New Staking Curve #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensojka
requested changes
Jul 25, 2024
scobi7
added a commit
to scobi7/konoha
that referenced
this pull request
Jul 25, 2024
tensojka
requested changes
Aug 6, 2024
| let unlock_date = current_time + lock_duration; | ||
| assert(unlock_date > current_time, 'can only lock in the future(CL)'); | ||
|
|
||
| //maybe a max time assertion? |
There was a problem hiding this comment.
Yes definitely, also set MAX_TIME to 2 yrs
| } | ||
| ); | ||
| } | ||
| fn withdraw(ref self: ComponentState<TContractState>, caller: ContractAddress) { |
There was a problem hiding this comment.
I don't think you burn the locked token anywhere?
There was a problem hiding this comment.
if caller is withdrawing their staked tokens, shouldn't it be transferred back to them and not burned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Staking Curve that implements linear decay. Allows for you to create a lock that sets the staking amount and time you will lock it for (create_lock(amount, lock_time). Basically queries when you do so and keeps track of locked amount and lock creation time. Then if you call get_balance_of, it applies linear decay formula which to calculate your current amount at this time stamp.
IMPORTANT:
by changing the functions like set_staking_curve, it affected almost all other test files that used these functions like test_treasury.
Not sure what we must do about this, since both curves are different.