Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: matching compressions should be checked when appending rasters #165

Merged
merged 3 commits into from
Mar 10, 2025
Merged

fix: matching compressions should be checked when appending rasters #165

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d16a19f
check compression when updating metadata
vdelacruzb Feb 20, 2025
bb6af29
fix snowflake bug
vdelacruzb Mar 10, 2025
d6f1c7c
remove prints
vdelacruzb Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions raster_loader/io/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,12 @@ def check_metadata_is_compatible(metadata, old_metadata):
f"({metadata['bands']} != {old_metadata['bands']})."
)

if metadata.get("compression") != old_metadata.get("compression"):
raise ValueError(
"Cannot append records to a table with different compression."
f"({metadata.get('compression')} != {old_metadata.get('compression')})."
)


def update_metadata(metadata, old_metadata):
"""Update a metadata object, combining it with another existing metadata object
Expand Down
11 changes: 10 additions & 1 deletion raster_loader/io/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,12 @@ def band_rename_function(x):
exit()

metadata = rasterio_metadata(
file_path, bands_info, band_rename_function, exact_stats, basic_stats
file_path,
bands_info,
band_rename_function,
exact_stats,
basic_stats,
compress,
)

overviews_records_gen = rasterio_overview_to_records(
Expand Down Expand Up @@ -297,7 +302,11 @@ def band_rename_function(x):

print("Writing metadata to Snowflake...")
if append_records:
print("Appending records to Snowflake...")
print(f"Metadata: {metadata}")
print(f"Append records: {append_records}")
old_metadata = self.get_metadata(fqn)
print(f"Old metadata: {old_metadata}")
check_metadata_is_compatible(metadata, old_metadata)
update_metadata(metadata, old_metadata)

Expand Down