Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests.yml #226

Closed
wants to merge 11 commits into from
Closed

Update tests.yml #226

wants to merge 11 commits into from

Conversation

johnnynunez
Copy link
Contributor

No description provided.

@johnnynunez
Copy link
Contributor Author

@iMichka merge please

@iMichka
Copy link
Contributor

iMichka commented Jan 31, 2025

Hello

Thanks for the improvement, this is something that was on my todo list :)

Can you check the error in the workflow file?

The workflow is not valid. .github/workflows/tests.yml (Line: 210, Col: 9): 'if' is already defined .github/workflows/tests.yml (Line: 211, Col: 9): 'run' is already defined

We might need to split this up in multiple pull requests. I expect some tests to break too

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Jan 31, 2025

Hello

Thanks for the improvement, this is something that was on my todo list :)

Can you check the error in the workflow file?

The workflow is not valid. .github/workflows/tests.yml (Line: 210, Col: 9): 'if' is already defined .github/workflows/tests.yml (Line: 211, Col: 9): 'run' is already defined

We might need to split this up in multiple pull requests. I expect some tests to break too

I will check
FYI: I have another PR: CastXML/CastXMLSuperbuild#63

@johnnynunez
Copy link
Contributor Author

@iMichka Done!

@johnnynunez
Copy link
Contributor Author

@iMichka can you merge it?

@johnnynunez johnnynunez mentioned this pull request Jan 31, 2025
@johnnynunez
Copy link
Contributor Author

@iMichka updated also and working!
CastXML/CastXMLSuperbuild#63

@iMichka
Copy link
Contributor

iMichka commented Feb 6, 2025

I think this really touches too many things at once, and it will be hard to debug.

Any variation of:

  • The binder Dockerfile update can be done separately
  • The Python 3.13 support update in a second PR
  • Then updating castxml to the latest version
  • Adding ARM runners at the very end

would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants