Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking/drop ledger account index #101

Merged
merged 4 commits into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/dev_documentation/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
- 🚨 BREAKING CHANGE 🚨 OptionalValue are mandatory now (user must input "null")
- 🚨 BREAKING CHANGE 🚨 Enums format has changed to use the one from the multiversx-sdk-py
- 🚨 BREAKING CHANGE 🚨 MultiValueEncoded format has changed to use the one from the multiversx-sdk-py
- 🚨 BREAKING CHANGE 🚨 ledger account index was dropped as it is not used by multiversx-sdk-py


## 2.2.0 - 2024-04-16
Expand Down
1 change: 0 additions & 1 deletion docs/source/user_documentation/scenes.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ accounts:
pem_path: path/to/bom_pem

- account_name: alice
ledger_account_index: 12
ledger_address_index: 2

- name: user_wallets
Expand Down
5 changes: 1 addition & 4 deletions mxops/execution/account.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ def load_register_account(
cls,
account_name: str,
pem_path: str | Path | None = None,
ledger_account_index: int | None = None,
ledger_address_index: int | None = None,
):
"""
Expand All @@ -66,16 +65,14 @@ def load_register_account(
:type account_name: str
:param pem_path: string path to the PEM file, defaults to None
:type pem_path: Optional[Path], optional
:param ledger_account_index: index of the ledger account, defaults to None
:type ledger_account_index: Optional[int], optional
:param ledger_address_index: index of the ledger address, defaults to None
:type ledger_address_index: Optional[int], optional
"""
if isinstance(pem_path, str):
pem_path = Path(pem_path)
if isinstance(pem_path, Path):
account = Account.new_from_pem(pem_path)
elif ledger_account_index is not None and ledger_address_index is not None:
elif ledger_address_index is not None:
account = LedgerAccount(ledger_address_index)
else:
raise ValueError(f"{account_name} is not correctly configured")
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "mxops"
version = "3.0.0-dev24"
version = "3.0.0-dev25"
authors = [
{name="Etienne Wallet"},
]
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 3.0.0-dev24
current_version = 3.0.0-dev25
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(-(?P<release>[^-0-9]+)(?P<build>\d+))?
serialize =
{major}.{minor}.{patch}-{release}{build}
Expand Down