Fix ember.built in components.legacy-attribute-arguments; Fix `embe…

…r.built-in-components.reopen` (#1987)
CenterForOpenScience · Sep 4, 2023 · bcc5611 · bcc5611
1 parent 60a8ad8
commit bcc5611
Show file tree

Hide file tree

Showing 44 changed files with 114 additions and 183 deletions.
diff --git a/app/institutions/index/template.hbs b/app/institutions/index/template.hbs
@@ -49,11 +49,11 @@
                     <Input
                         data-test-institutions-filter='filter'
                         aria-label={{t 'institutions.search_placeholder'}}
+                        placeholder={{t 'institutions.search_placeholder'}}
+                        class='form-control'
                         @value={{this.textValue}}
                         @type='text'
-                        @class='form-control'
-                        @placeholder={{t 'institutions.search_placeholder'}}
-                        @keyPress={{perform this.trackFilter}}
+                        {{on 'keypress' (perform this.trackFilter)}}
                     />
                 </div>
             </div>

diff --git a/app/meetings/detail/-components/meeting-submissions-list/template.hbs b/app/meetings/detail/-components/meeting-submissions-list/template.hbs
@@ -1,10 +1,10 @@
 <div data-test-submissions-list-search local-class='search-container'>
     <Input
         local-class='search {{if this.isMobile 'mobile'}}'
-        @type='text'
-        @placeholder={{t 'meetings.index.meetings-list.search'}}
-        @key-up={{perform this.searchSubmissions}}
+        placeholder={{t 'meetings.index.meetings-list.search'}}
         aria-label={{t 'meetings.index.meetings-list.search'}}
+        @type='text'
+        {{on 'keyup' (perform this.searchSubmissions)}}
     />
 </div>
 

diff --git a/app/meetings/index/-components/meetings-list/template.hbs b/app/meetings/index/-components/meetings-list/template.hbs
@@ -7,9 +7,9 @@
         <Input
             local-class='search-input'
             aria-label={{t 'meetings.index.meetings-list.search'}}
+            placeholder={{t 'meetings.index.meetings-list.search'}}
             @type='text'
-            @placeholder={{t 'meetings.index.meetings-list.search'}}
-            @key-up={{perform this.searchMeetings}}
+            {{on 'keyup' (perform this.searchMeetings)}}
         />
     </div>
 </div>

diff --git a/config/deprecation-workflow.js b/config/deprecation-workflow.js
@@ -9,8 +9,6 @@ self.deprecationWorkflow.config = {
         { handler: 'silence', matchId: 'ember-cli-mirage-config-routes-only-export' },
         { handler: 'silence', matchId: 'ember-engines.deprecation-router-service-from-host'},
         { handler: 'silence', matchId: 'ember-test-waiters-legacy-module-name'},
-        { handler: 'silence', matchId: 'ember.built-in-components.legacy-attribute-arguments'},
-        { handler: 'silence', matchId: 'ember.built-in-components.reopen'},
         { handler: 'silence', matchId: 'ember.component.reopen'},
         { handler: 'silence', matchId: 'ember-global'},
         { handler: 'silence', matchId: 'ember.link-to.disabled-when'},

diff --git a/lib/app-components/addon/components/branded-navbar/template.hbs b/lib/app-components/addon/components/branded-navbar/template.hbs
@@ -11,7 +11,6 @@
             <div class='navbar-header'>
                 <LinkTo 
                     @route={{@brandRoute}}
-                    @provider={{this.theme.provider}}
                     class='navbar-brand'
                 >
                     <span local-class='navbar-image' class='navbar-image'></span>

diff --git a/lib/app-components/addon/components/project-contributors/list/item/template.hbs b/lib/app-components/addon/components/project-contributors/list/item/template.hbs
@@ -64,10 +64,11 @@
         >
             <Input
                 aria-label={{t 'app_components.project_contributors.list.item.in_citation_label'}}
+                disabled={{not this.canChangeBibliographic}}
                 @type='checkbox'
-                @disabled={{not this.canChangeBibliographic}}
                 @checked={{@contributor.bibliographic}}
-                @change={{action @toggleBibliographic @contributor}} />
+                {{on 'change' (fn @toggleBibliographic @contributor)}}
+            />
 
             {{#if this.isMobile}}
                 <FaIcon @icon='question-circle' />

diff --git a/lib/app-components/addon/components/project-contributors/search/template.hbs b/lib/app-components/addon/components/project-contributors/search/template.hbs
@@ -5,9 +5,9 @@
     >
         <Input
             aria-label={{t 'app_components.project_contributors.search.placeholder'}}
-            @class='form-control'
+            class='form-control'
+            placeholder={{t 'app_components.project_contributors.search.placeholder'}}
             @value={{this.query}}
-            @placeholder={{t 'app_components.project_contributors.search.placeholder'}}
         />
         <span local-class='input-group-btn'>
             <Button

diff --git a/...n/components/collections-submission/collection-submission-confirmation-modal/template.hbs b/...n/components/collections-submission/collection-submission-confirmation-modal/template.hbs
@@ -17,7 +17,7 @@
                 <Textarea
                     data-test-collection-submission-confirmation-modal-reason
                     local-class='remove-textarea'
-                    @placeholder={{t 'collections.collection_submission_confirmation_modal.resubmit_reason_placeholder'}}
+                    placeholder={{t 'collections.collection_submission_confirmation_modal.resubmit_reason_placeholder'}}
                     @value={{this.removeReason}}
                 />
             </div>

diff --git a/lib/collections/addon/components/collections-submission/template.hbs b/lib/collections/addon/components/collections-submission/template.hbs
@@ -190,7 +190,7 @@
                             <Textarea
                                 data-test-collections-remove-reason
                                 local-class='remove-textarea'
-                                @placeholder={{t (concat this.intlKeyPrefix 'remove_reason_placeholder')}}
+                                placeholder={{t (concat this.intlKeyPrefix 'remove_reason_placeholder')}}
                                 @value={{this.removeReason}}
                             />
                         </div>

diff --git a/lib/collections/addon/components/discover-page/facets/checklist/template.hbs b/lib/collections/addon/components/discover-page/facets/checklist/template.hbs
@@ -6,7 +6,7 @@
                     <Input
                         @type='checkbox'
                         @checked={{item.checked}}
-                        @change={{action this.updateFilters item.key}}
+                        {{on 'change' (fn this.updateFilters item.key)}}
                     />
                     {{item.key}}
                 </label>

diff --git a/lib/collections/addon/components/discover-page/facets/collection-provider/template.hbs b/lib/collections/addon/components/discover-page/facets/collection-provider/template.hbs
@@ -4,10 +4,10 @@
             <li data-test-collection-provider-facet-item={{item.key}}>
                 <label local-class='provider-label'>
                     <Input
+                        disabled={{this.theme.isProvider}}
                         @type='checkbox'
                         @checked={{item.checked}}
-                        @change={{action this.updateFilters item.key}}
-                        @disabled={{this.theme.isProvider}}
+                        {{on 'change' (fn this.updateFilters item.key)}}
                     />
                     {{filter-replace item.key @filterReplace}}
                     <small>({{format-number item.doc_count}})</small>

diff --git a/lib/collections/addon/components/discover-page/template.hbs b/lib/collections/addon/components/discover-page/template.hbs
@@ -43,19 +43,19 @@
         {{!SEARCH BAR}}
         <Input
             local-class='input'
+            class='form-control'
             aria-label={{t
                 (or this.searchPlaceholder 'collections.discover_page.searchPlaceholder')
                 documentType=this.themeProvider.documentType
             }}
-            @id='searchBox'
-            @value={{this.q}}
-            @class='form-control'
-            @enter={{action this.searchAction}}
-            @key-up={{action this.searchAction}}
-            @placeholder={{t
+            placeholder={{t
                 (or this.searchPlaceholder 'collections.discover_page.searchPlaceholder')
                 documentType=this.themeProvider.documentType
             }}
+            id='searchBox'
+            @value={{this.q}}
+            @enter={{this.searchAction}}
+            {{on 'keyup' this.searchAction}}
         />
         <div local-class='input-group-btn'>
             {{!HELP BUTTON}}

diff --git a/lib/osf-components/addon/components/contributor-list/unregistered-contributor/template.hbs b/lib/osf-components/addon/components/contributor-list/unregistered-contributor/template.hbs
@@ -46,9 +46,9 @@
                 <label local-class='emailLabel'>
                     {{t 'contributor_list.unregistered_contributor.enterEmail'}}
                     <Input
-                        local-class='emailInput'
                         data-test-email-input
-                        @placeholder={{t 'contributor_list.unregistered_contributor.emailPlaceholder'}}
+                        local-class='emailInput'
+                        placeholder={{t 'contributor_list.unregistered_contributor.emailPlaceholder'}}
                         @value={{get this.emailChangeset 'userEmail'}}
                     />
                     <ValidationErrors

diff --git a/lib/osf-components/addon/components/contributors/user-search/card/template.hbs b/lib/osf-components/addon/components/contributors/user-search/card/template.hbs
@@ -42,7 +42,7 @@
                 <Input
                     @type='checkbox'
                     @checked={{readonly this.isBibliographic}}
-                    @disabled={{this.isAdded}}
+                    disabled={{this.isAdded}}
                     data-test-user-citation-checkbox={{@user.id}}
                     data-analytics-name='Toogle isBibliographic'
                     {{on 'click' this.toggleIsBibliographic}}

diff --git a/lib/osf-components/addon/components/contributors/user-search/widget/template.hbs b/lib/osf-components/addon/components/contributors/user-search/widget/template.hbs
@@ -3,8 +3,8 @@
         <Input
             local-class='UserSearchInput'
             data-test-user-search-input
+            placeholder={{t 'registries.registration_metadata.add_contributors.search_placeholder'}}
             @type='text'
-            @placeholder={{t 'registries.registration_metadata.add_contributors.search_placeholder'}}
             @value={{this.query}}
             @enter={{perform this.fetchUsers false}}
         />

diff --git a/lib/osf-components/addon/components/delete-button/template.hbs b/lib/osf-components/addon/components/delete-button/template.hbs
@@ -61,7 +61,7 @@
                 </p>
                 <Input
                     local-class='DeleteModal__input'
-                    @class='form-control'
+                    class='form-control'
                     @value={{this.scientistInput}}
                 />
             </label>

diff --git a/lib/osf-components/addon/components/delete-node-modal/template.hbs b/lib/osf-components/addon/components/delete-node-modal/template.hbs
@@ -12,7 +12,7 @@
             <p local-class='DeleteModal__input-label'>{{t 'delete_modal.type_this'}} <strong>{{this.scientistName}}</strong></p>
             <Input
                 local-class='DeleteModal__input'
-                @class='form-control'
+                class='form-control'
                 @value={{this.scientistInput}}
             />
         </label>

diff --git a/lib/osf-components/addon/components/institution-select-list/template.hbs b/lib/osf-components/addon/components/institution-select-list/template.hbs
@@ -13,10 +13,10 @@
                     <Input
                         data-test-institution-button={{concat (if isAffiliated 'remove' 'add') '-' institution.id}}
                         data-analytics-name={{if isAffiliated 'Remove' 'Add'}}
+                        disabled={{@manager.shouldDisable}}
                         @type='checkbox'
                         @checked={{isAffiliated}}
-                        @disabled={{@manager.shouldDisable}}
-                        @change={{action @manager.toggleInstitution institution}}
+                        {{on 'change' (fn @manager.toggleInstitution institution)}}
                     />
                 {{/let}}
                 {{institution.name}}

diff --git a/lib/osf-components/addon/components/license-picker/template.hbs b/lib/osf-components/addon/components/license-picker/template.hbs
@@ -41,11 +41,11 @@
             <label for='nodeLicense-{{key}}'>{{t (concat 'app_components.license_picker.fields.' key)}}</label>
             <br>
             <Input
-                @class='form-control'
-                @id={{concat 'nodeLicense-' key}}
+                class='form-control'
+                id={{concat 'nodeLicense-' key}}
+                placeholder={{t 'general.required'}}
                 @value={{readonly (get this.form.changeset.nodeLicense key)}}
-                @change={{fn this.updateNodeLicense key}}
-                @placeholder={{t 'general.required'}}
+                {{on 'change' (fn this.updateNodeLicense key)}}
             />
         {{/each}}
     </this.form.custom>

diff --git a/lib/osf-components/addon/components/new-project-modal/template.hbs b/lib/osf-components/addon/components/new-project-modal/template.hbs
@@ -14,13 +14,13 @@
                     {{t 'general.title'}}
                     <Input
                         data-test-new-project-title
-                        @placeholder={{t 'new_project.title_placeholder'}}
-                        @autofocus='autofocus'
-                        @class='form-control'
-                        @required={{true}}
+                        placeholder={{t 'new_project.title_placeholder'}}
+                        autofocus={{true}}
+                        class='form-control'
+                        required={{true}}
                         @value={{this.nodeTitle}}
                         @type='text'
-                        @enter={{action this.create}}
+                        @enter={{this.create}}
                     />
                 </label>
             </div>
@@ -105,8 +105,8 @@
                         {{t 'general.description'}}
                         <Input
                             data-test-project-description-input
-                            @placeholder={{t 'new_project.description_placeholder'}}
-                            @class={{concat 'form-control ' (local-class 'noresize')}}
+                            placeholder={{t 'new_project.description_placeholder'}}
+                            class={{concat 'form-control ' (local-class 'noresize')}}
                             @value={{this.description}}
                             @type='text'
                         />

diff --git a/lib/osf-components/addon/components/node-publication-doi-editable/template.hbs b/lib/osf-components/addon/components/node-publication-doi-editable/template.hbs
@@ -11,8 +11,8 @@
             <Input
                 @value={{get @manager.changeset 'articleDoi'}}
                 @type='text'
-                @class='form-control'
-                @placeholder={{this.doiPlaceholder}}
+                class='form-control'
+                placeholder={{this.doiPlaceholder}}
             />
         </div>
     </ValidatedInput::Custom>

diff --git a/lib/osf-components/addon/components/osf-mode-footer/template.hbs b/lib/osf-components/addon/components/osf-mode-footer/template.hbs
@@ -17,7 +17,7 @@
                     <Input
                         @type='text'
                         @value={{this.url}}
-                        @enter={{action this.transitionToUrl}}
+                        @enter={{this.transitionToUrl}}
                     />
                 {{/if}}
             </div>
@@ -78,8 +78,8 @@
                             <label>
                                 <Input
                                     @type='checkbox'
-                                    @click={{action this.toggleFeature feature}}
                                     @checked={{is-feature-enabled this.features feature}}
+                                    {{on 'click' (fn this.toggleFeature feature)}}
                                 />
                                 {{feature}}
                             </label>

diff --git a/lib/osf-components/addon/components/provider-metadata-editable/template.hbs b/lib/osf-components/addon/components/provider-metadata-editable/template.hbs
@@ -8,10 +8,10 @@
     >
         {{@field.field_name}}
     </span>
-    {{input
-        data-test-provider-metadata-edit-input=@field.field_name
+    <Input
+        data-test-provider-metadata-edit-input={{@field.field_name}}
+        disabled={{@manager.save.isRunning}}
         class='form-control'
-        value=@field.field_value
-        disabled=@manager.save.isRunning
-    }}
+        @value={{@field.field_value}}
+    />
 </div>
diff --git a/lib/osf-components/addon/components/registries/hierarchical-list/item/template.hbs b/lib/osf-components/addon/components/registries/hierarchical-list/item/template.hbs
@@ -1,9 +1,9 @@
 <li data-test-item={{@manager.item.id}}>
     <Input
+        disabled={{@manager.isRoot}}
         @type='checkbox'
-        @change={{action @manager.onChange}}
         @checked={{@manager.itemChecked}}
-        @disabled={{@manager.isRoot}}
+        {{on 'change' @manager.onChange}}
     />
     <Button
         local-class='expand-button'

diff --git a/lib/osf-components/addon/components/search-bar/template.hbs b/lib/osf-components/addon/components/search-bar/template.hbs
@@ -12,11 +12,11 @@
         <Input
             data-test-search-input
             aria-label={{t 'osf-components.search-bar.aria'}}
-            @name='search'
+            placeholder={{t 'osf-components.search-bar.placeholder'}}
+            name='search'
             @type='text'
-            @placeholder={{t 'osf-components.search-bar.placeholder'}}
-            @enter={{action this._onSearch this.value}}
             @value={{mut this.value}}
+            @enter={{fn this._onSearch this.value}}
         />
     </span>
 </div>
diff --git a/lib/osf-components/addon/components/search-page/template.hbs b/lib/osf-components/addon/components/search-page/template.hbs
@@ -53,8 +53,8 @@ as |layout|>
                 data-test-search-input
                 data-analytics-name='Search input'
                 local-class='search-input'
+                placeholder={{t 'search.textbox-placeholder'}}
                 @type='search'
-                @placeholder={{t 'search.textbox-placeholder'}}
                 @value={{this.cardSearchText}}
                 @enter={{perform this.doDebounceSearch}}
             />

diff --git a/lib/osf-components/addon/components/subjects/browse/item/template.hbs b/lib/osf-components/addon/components/subjects/browse/item/template.hbs
@@ -10,8 +10,8 @@
     >
         <Input
             @type='checkbox'
-            @change={{action @singleSubjectManager.toggleSelected}}
             @checked={{@singleSubjectManager.isSelected}}
+            {{on 'change' @singleSubjectManager.toggleSelected}}
         />
         {{#if this.isPlaceholder}}
             {{random-text wordsPerSentence=3}}

diff --git a/lib/osf-components/addon/components/subjects/search/search-result/template.hbs b/lib/osf-components/addon/components/subjects/search/search-result/template.hbs
@@ -2,10 +2,10 @@
     {{#let (unique-id 'search-result') as |inputId|}}
         <Input
             data-test-subject-search-result-checkbox='{{this.subject.text}}'
-            @id={{inputId}}
+            id={{inputId}}
             @type='checkbox'
-            @change={{@singleSubjectManager.toggleSelected}}
             @checked={{@singleSubjectManager.isSelected}}
+            {{on 'change' @singleSubjectManager.toggleSelected}}
         />
 
         <span local-class='Ancestry'>

diff --git a/lib/osf-components/addon/components/subjects/search/template.hbs b/lib/osf-components/addon/components/subjects/search/template.hbs
@@ -6,11 +6,11 @@
     />
     <Input
         data-test-subject-searchbox
-        @name='search'
+        placeholder={{t 'osf-components.subjects.search.placeholder'}}
+        name='search'
         @type='text'
         @value={{this.userQuery}}
-        @placeholder={{t 'osf-components.subjects.search.placeholder'}}
-        @key-up={{action (perform this.doSearch)}}
+        {{on 'keyup' (perform this.doSearch)}}
     />
 </div>
 

diff --git a/lib/osf-components/addon/components/validated-input/checkbox/template.hbs b/lib/osf-components/addon/components/validated-input/checkbox/template.hbs
@@ -9,11 +9,11 @@
 }}
     <label>
         <Input
-            @id={{inputElementId}}
+            id={{inputElementId}}
+            name={{this.valuePath}}
+            disabled={{this.disabled}}
             @type='checkbox'
             @checked={{this.value}}
-            @name={{this.valuePath}}
-            @disabled={{this.disabled}}
         />
         {{yield}}
     </label>