CR feedback

CenterForOpenScience · Sep 23, 2024 · f59ca6e · f59ca6e
1 parent 998de1b
commit f59ca6e
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 58 deletions.
diff --git a/app/institutions/dashboard/-components/object-list/link-field/component.ts b/app/institutions/dashboard/-components/object-list/link-field/component.ts
diff --git a/app/institutions/dashboard/-components/object-list/link-field/template.hbs b/app/institutions/dashboard/-components/object-list/link-field/template.hbs
diff --git a/app/institutions/dashboard/-components/object-list/template.hbs b/app/institutions/dashboard/-components/object-list/template.hbs
@@ -25,11 +25,12 @@ as |list|>
                                 {{#each @columns as |column|}}
                                     <td>
                                         {{#if (eq column.type 'link')}}
-                                            <Institutions::Dashboard::-Components::ObjectList::LinkField
-                                                @searchResult={{result}}
-                                                @getHref={{column.getHref}}
-                                                @getLinkText={{column.getLinkText}}
-                                            />
+                                            <OsfLink
+                                                @href={{call (fn column.getHref result)}}
+                                                @target='_blank'
+                                            >
+                                                {{call (fn column.getLinkText result)}}
+                                            </OsfLink>
                                         {{else if (eq column.type 'doi')}}
                                             <Institutions::Dashboard::-Components::ObjectList::DoiField
                                                 @searchResult={{result}}
@@ -40,10 +41,7 @@ as |list|>
                                                 @institution={{@institution}}
                                             />
                                         {{else}}
-                                            <Institutions::Dashboard::-Components::ObjectList::TextField
-                                                @searchResult={{result}}
-                                                @getterFunction={{column.getValue}}
-                                            />
+                                            {{call (fn column.getValue result)}}
                                         {{/if}}
                                     </td>
                                 {{/each}}

diff --git a/app/institutions/dashboard/-components/object-list/text-field/component.ts b/app/institutions/dashboard/-components/object-list/text-field/component.ts
diff --git a/app/institutions/dashboard/-components/object-list/text-field/template.hbs b/app/institutions/dashboard/-components/object-list/text-field/template.hbs
diff --git a/ember-cli-build.js b/ember-cli-build.js
@@ -32,7 +32,9 @@ module.exports = function(defaults) {
             ],
         },
         'ember-composable-helpers': {
-            only: ['compose', 'contains', 'flatten', 'includes', 'range', 'queue', 'map-by', 'without', 'find-by'],
+            only: [
+                'call', 'compose', 'contains', 'find-by', 'flatten', 'includes', 'map-by', 'queue', 'range', 'without',
+            ],
         },
         fingerprint: {
             enabled: true,