Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use environment variables for SHARE URLs #1849

Merged
merged 3 commits into from
Jul 11, 2024
Merged

use environment variables for SHARE URLs #1849

merged 3 commits into from
Jul 11, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Apr 21, 2023 •
edited
Loading

  • Ticket: []
  • Feature flag: n/a

Purpose

make it easier to run SHARE with OSF locally

Summary of Changes

  • update the registries discover page to use config instead of hard-coded URLs
  • update the collections discover page to stop referencing config it does not use
  • remove unused SHARE_API_URL config
  • default to local SHARE/trove (instead of staging-share)

Screenshot(s)

Side Effects

QA Notes

@aaxelb aaxelb mentioned this pull request Apr 21, 2023
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4767184875

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 72.45%
Totals Coverage Status
Change from base Build 4680403816: 0.006%
Covered Lines: 5735
Relevant Lines: 7701
💛 - Coveralls

@futa-ikeda futa-ikeda changed the base branch from develop to feature/search-improvements August 24, 2023 17:45
@aaxelb
registries discover with local SHARE
13544cf 
use existing environment variables instead of hard-coded URLs
    SHARE_BASE_URL
    SHARE_API_URL
    SHARE_SEARCH_URL
@aaxelb aaxelb changed the base branch from feature/search-improvements to feature/addon-services July 11, 2024 14:58
@aaxelb aaxelb requested a review from futa-ikeda July 11, 2024 14:58
futa-ikeda
futa-ikeda approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize we never merged this PR. Appreciate the updates!

@aaxelb aaxelb merged commit cef8421 into CenterForOpenScience:feature/addon-services Jul 11, 2024
9 checks passed
@aaxelb aaxelb deleted the quest/local-share branch July 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futa-ikeda futa-ikeda futa-ikeda approved these changes

@adlius adlius adlius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaxelb @coveralls @adlius @futa-ikeda