-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][ENG-4467]Search result card #1914
Merged
futa-ikeda
merged 25 commits into
CenterForOpenScience:feature/search-improvements
from
adlius:search-result-card
Aug 9, 2023
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e08eccc
prelim
adlius 5ae7b9f
some more
adlius a178a8d
moar
adlius e965769
moar
adlius ca34e25
moar
adlius bd5cfdd
some moar
adlius c605151
registration secondary metadata
adlius 74d0b85
prelim project secondary metadata
adlius e7e18a6
Add preprint-secondary-metadata
futa-ikeda 55e05f7
less verbose comments
futa-ikeda fe9f2be
prelim
adlius 61fb79b
some more
adlius c4e6fb7
moar
adlius cb52b0e
moar
adlius d9e233a
moar
adlius 988004f
some moar
adlius 9ada49c
registration secondary metadata
adlius a946c39
prelim project secondary metadata
adlius d3ff44f
added a bun of optional chaining to avoid errors
adlius 10604db
Merge remote-tracking branch 'futa/preprint-secondary-metadata' into …
adlius 3d76cd5
make sure context field works
adlius 80689e9
fix tests
adlius f0e604d
add open badges list to registration search results
adlius 4e7695e
fix open resource badges routing
adlius c4120a5
fix misc. stuff
adlius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,8 @@ | |
font-weight: 700; | ||
margin-top: 0; | ||
} | ||
|
||
.horizontal-layout { | ||
display: flex; | ||
gap: 10px; | ||
} |
122 changes: 85 additions & 37 deletions
122
lib/osf-components/addon/components/open-badges-list/template.hbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,85 @@ | ||
<div data-test-badge-list local-class='badgeList'> | ||
{{#unless this.isMobile}} | ||
<h5 data-test-badge-list-title local-class='title'> | ||
{{t 'osf-components.open-badges-list.title'}} | ||
</h5> | ||
{{/unless}} | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasData}} | ||
@resourceType='data' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasAnalyticCode}} | ||
@resourceType='analytic_code' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasMaterials}} | ||
@resourceType='materials' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasPapers}} | ||
@resourceType='papers' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasSupplements}} | ||
@resourceType='supplements' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
/> | ||
</div> | ||
{{#if @verticalLayout}} | ||
<div data-test-badge-list local-class='badgeList'> | ||
{{#unless this.isMobile}} | ||
<h5 data-test-badge-list-title local-class='title'> | ||
{{t 'osf-components.open-badges-list.title'}} | ||
</h5> | ||
{{/unless}} | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasData}} | ||
@resourceType='data' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasAnalyticCode}} | ||
@resourceType='analytic_code' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasMaterials}} | ||
@resourceType='materials' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasPapers}} | ||
@resourceType='papers' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasSupplements}} | ||
@resourceType='supplements' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
</div> | ||
{{else}} | ||
<h5 data-test-badge-list-title local-class='title'> | ||
{{t 'osf-components.open-badges-list.title'}} | ||
</h5> | ||
<div local-class='horizontal-layout'> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasData}} | ||
@resourceType='data' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasAnalyticCode}} | ||
@resourceType='analytic_code' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasMaterials}} | ||
@resourceType='materials' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasPapers}} | ||
@resourceType='papers' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
<OpenBadgesList::OpenBadgeCard | ||
@hasResource={{@hasSupplements}} | ||
@resourceType='supplements' | ||
@isMobile={{this.isMobile}} | ||
@registration={{@registration}} | ||
@absoluteUrl={{@absoluteUrl}} | ||
/> | ||
</div> | ||
{{/if}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to loosen the
includes
here to just bedoi.org
as I think a lot of the registrations on staging have a DOI ofdx.doi.org
or something of that nature