Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update help text #1960

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Update help text #1960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/search-page/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ as |layout|>
<h2 local-class='search-help-header' data-test-help-heading-3>
{{t 'search.search-help.header-3'}}
</h2>
<p data-test-help-body-3>{{t 'search.search-help.body-3'}}</p>
<p data-test-help-body-3>{{t 'search.search-help.body-3' htmlSafe=true}}</p>
<span local-class='pagination'>
<p local-class='enumeration' data-test-help-enumeration-3>{{t 'search.search-help.index-3'}}</p>
<span local-class='help-button-wrappers'>
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/search/search-help-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module('Integration | Component | Search help', hooks => {
assert.dom('[data-test-search-help-2]').exists();
// verify second popover content
assert.dom('[data-test-help-heading-2]').exists();
assert.dom('[data-test-help-heading-2]').hasText('OSF Smart Facets');
assert.dom('[data-test-help-heading-2]').hasText('Refine Your Search');
assert.dom('[data-test-help-body-2]').exists();
assert.dom('[data-test-help-body-2]').hasText(`Narrow the source, discipline, and more.
For example, find content supported by a specific funder or view only datasets.`);
Expand All @@ -53,7 +53,7 @@ module('Integration | Component | Search help', hooks => {
assert.dom('[data-test-help-heading-3]').hasText('Add Metadata');
assert.dom('[data-test-help-body-3]').exists();
assert.dom('[data-test-help-body-3]').hasText(`Remember to add metadata and resources
to your own work on OSF to make it more discoverable!`);
to your own work on OSF to make it more discoverable! Learn more in our help guides.`);
assert.dom('[data-test-help-enumeration-3]').exists();
assert.dom('[data-test-help-enumeration-3]').hasText('3 of 3');

Expand Down
4 changes: 2 additions & 2 deletions translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ search:
no-title: 'No title found'
search-help:
header-1: 'Improved OSF Search'
header-2: 'OSF Smart Facets'
header-2: 'Refine Your Search'
header-3: 'Add Metadata'
body-1: 'Enter any term in the search box and filter by specific object types. More information is available on our <a href="https://help.osf.io/article/588-getting-started-with-osf-search" target="_blank" rel="noopener noreferrer">help guides</a>.'
body-2: 'Narrow the source, discipline, and more. For example, find content supported by a specific funder or view only datasets.'
body-3: 'Remember to add metadata and resources to your own work on OSF to make it more discoverable!'
body-3: 'Remember to add metadata and resources to your own work on OSF to make it more discoverable! Learn more in our <a href="https://help.osf.io/article/572-metadata-to-increase-discoverability" target="_blank" rel="noopener noreferrer">help guides</a>.'
index-1: '1 of 3'
index-2: '2 of 3'
index-3: '3 of 3'
Expand Down
Loading