[ENG-4013] Barium/deprecation this property fallback #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(And break tests)
…llback # Conflicts: # app/services/theme.ts # lib/osf-components/addon/components/editable-field/tags-manager/component.ts # lib/osf-components/addon/components/tags-widget/component.ts # lib/registries/addon/drafts/draft/-components/tags-manager/component.ts
brianjgeiger
commented
Aug 30, 2023
adlius
approved these changes
Aug 30, 2023
chth0n1x
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Hi Brian, most of these changes look good. However, I did encounter some issues during the testing of the PR:
The stack trace is now very large. It seems that there are a number of deprecation notices where the compiler was expecting certain classes but received another. If there is a way to resolve the deprecation notices in this PR that seems most appropriate.
Second, the ‘Create new’ registration button results now in a faulty error message, namely that it is now blank but still alerts the user with a red error box at the top right.
On the create draft page, there is latency with loading the contributor list. This results in error messages firing that may be unnecessarily alerting the user. The list also takes several times to load where the loading indicator will time out.
Contributors when able to be added are able to be sorted in order so the fix will work it is just getting there that seems to take time.
Is there a way to clear the deprecation notices for this PR? Do we know what ramifications a lengthy stack trace will have on the front-end load speed? Or does it not matter on Production?
If these do not matter or are not in scope for the PR, I can approve these changes. Well done!
|
@chth0n1x The messages during build shouldn't have any effect on page load times; that's all handled before page load, so we should be fine there. Yeah, there are more messages, and that's part of the 3.28 upgrade, but not this PR per se. It'll be something we need to deal with, but it's not causing problem-problems yet, so it'll probably have to wait a bit. I'm not seeing the problems you are with the create registrations or the create drafts pages in my local setup. Are you running a real back-end, or is this with mirage? |
brianjgeiger
merged commit 9ba7964
into
CenterForOpenScience:basket/barium
9 checks passed
Ok, that sounds good. Yes, it was with the real back-end, not with Mirage. |
adlius
added a commit
that referenced
this pull request
Sep 28, 2023
* [ENG-4012] Un-silence deprecation manager-capabilities.modifiers-3-13 (#1889) ## Purpose Un-silence the deprecation `manager-capabilities.modifiers-3-13` and fix the resulting problems ## Summary of Changes 1. Unsilence deprecation 2. Upgrade ember-auto-import to v2 3. Upgrade ember-modifiers 4. Upgrade ember-moment and imports 5. Spread moment around all the engines 6. Refactor modifiers to work with new api for ember-modifiers 7. Remove unused modifier 8. Fix usage of side-effect from ember computed to give ember power select a placeholder in institutional dashboard ## Side Effects If I didn't fix the modifiers right, something may have broken there silently. * Fix the missing asset prefix for ember-auto-import (#1906) ## Purpose Staging2 is broken because we can't find `chunk*.js` and it looks like that's because we need to add our `assetsPrefix` to ember-auto-import to make it work. This fix seems to work locally, but it works locally without the fix, so we'll see what actually happens on staging2. ## Summary of Changes 1. Fix the missing asset prefix * [ENG-4591] Barium/upgrade ember 3.28 (#1899) ## Purpose Upgrade ember to 3.28 ## Summary of Changes 1. Match ember dependencies to `ember new` blueprint 2. Fix all the problems 3. Modify getApiErrorMessage to re-throw in the case of no API error message (some problems fixed h/t @futa-ikeda) * [ENG-4488] Remove ember-cli-clipboard (#1910) ## Purpose Ember-cli-clipboard was doing deprecated things, and upgrading it was a nightmare. The actual functionality is trivial to implement, though, so we've made our own version of its copy button. ## Summary of Changes 1. Add copy button 2. Add tests * Don't re-throw error in getApiErrorMessage (#1911) ## Purpose See if a weird bug gets fixed on staging2 by removing a slightly risky re-throw of error messages. ## Summary of Changes 1. Don't re-throw error message * [No ticket] Throw an error when registries overview page errors (#1912) ## Purpose Help to be able to debug situations where the registries overview page goes to the not-found page inappropriately. ## Summary of Changes 1. Send the error to sentry after transitioning to page not found. * Remove most non-dirty relationships (#1918) ## Purpose When upgrading to ember 3.28, we lost the ability to distinguish between dirty relationships and clean ones when PATCHing a record, so we would send all the relationships. This was a problem because many of the clean relationships in the serializer had null information, which broke the API, because it doesn't like PATCHed relationships with null information. This fixes that by removing any relationship that is just null info in the serializer. We will still sometimes PATCH relationships we don't need to, but the info should be the same and thus not cause problems for the API. ## Summary of Changes 1. Scan for null relationships in osf-serializer and remove them from the request payload. * Fix infinite scrolling loader (#1919) ## Purpose The infinite scroller stopped working because the component that manages if it's in the viewport was not compatible with the new modifiers until it was updated. ## Summary of Changes 1. Update ember-in-viewport * [No ticket] Remove clean relationships from PATCH request (#1925) ## Purpose Properly remove clean relationships from a PATCH request. ## Summary of Changes 1. Get the graph 2. Scan the graph for changes in each relationship in the serializer 3. Remove the relationship from the serializer if there are no changes 4. Types * Make relationships polymorphic (#1928) ## Purpose Make registrations load on basket/barium release ## Summary of Changes 1. Make relationships polymorphic * [ENG-4025] Deprecation: has-block-and-has-block-params (#1909) ## Purpose - Address deprecation: [has-block-and-has-block-params](https://deprecations.emberjs.com/v3.x#toc_has-block-and-has-block-params) ## Summary of Changes - Remove `ember-cli-password-strength` and use `zxcvbn` directly - Remove `ember-promise-helpers` as it doesn't seem to be used - Update liquid-fire - Update ember-radio-buttons - Remove deprecation silencer Co-authored-by: Brian J. Geiger <[email protected]> * Remove test that accidentally merged in (#1977) * [ENG-4013] Barium/deprecation this property fallback (#1970) ## Purpose Eliminate this-property-fallback deprecation errors. Might want to review this commit-by-commit. The removal of ember-get-config added a bunch of noise. ## Summary of Changes 1. Upgrade ember-sortable 2. Fix tests that failed this deprecation 3. Upgrade: - ember-cli-showdown - tag-input - Ember-collapsible-panel - Ember-content-placeholders - Ember-radio-button 4. Remove ember-get-config 5. Move environment.d.ts 6. Fix tests * remove 'argument-less-helper-paren-less-invocation' (#1978) * Unsilence deprecation route-render-template (#1984) ## Purpose Fix deprecation route-render-template ## Summary of Changes 1. Unsilence the deprecation * Fix `ember.built-in-components.import` deprecation by upgrading ember-flatpickr (#1982) * fix deprecation by upgrading ember-flatpickr * use null as date param for ember-flatpickr * Fix `deprecated-run-loop-and-computed-dot-access` by upgrading ember-responsive and ember-intl; fix `ember.built-in-components.legacy-arguments` (#1983) * Fix `ember.built in components.legacy-attribute-arguments`; Fix `ember.built-in-components.reopen` (#1987) * Try to fix selenium test (#1988) ## Purpose Try to fix a selenium test that was broken when we re-wrote the clipboard button. ## Summary of Changes 1. Add data selector * Update ember-composable-helpers (#1980) ## Purpose There are two major parts to fixing the try-invoke deprecation. The first is updating ember-composable-helpers, and the second is removing ember parachute. This handles the first. The second will be part of Search Phase 2 once the branded registries discovery page, which is the page that uses ember-parachute, is removed. ## Summary of Changes 1. Update ember-composable-helpers * Fix broken meetings searches (#1991) ## Purpose A recent deprecation fix caused meetings searches to break. This should fix that. ## Summary of Changes 1. Add `target` string to `on` actions * Fix some build-time deprecations (#1989) ## Purpose Fix some build-time deprecations. Everything I know about except for https://deprecations.emberjs.com/v3.x/#toc_ember-global ## Summary of Changes 1. Upgrade ember power select 2. Upgrade Node 3. Remove node-sass 4. Remove ember-component-attributes 5. Fix usage of htmlSafe 6. Upgrade ember-cli-string-helpers 7. Remove unused osf-logo component 8. Update and remove various other dependencies ## Side effects Builds may be a bit faster. I'm getting between 45 and 60ish second builds, although this may only be true for M1 and M2 chips. Could be slower on Intel. Also, we'll get a bunch of extraneous notices in the buld process like `unexpectedly found "<Pane" when slicing source, but expected "class"`. This is unfortunate but expected and isn't supposed to hurt anything. * [ENG-4293] Fix node license validation (#1996) * fix node license validation * remove comments * add test * revert changes to copyMetadataChangesToDraft * Restore placeholder text on sign-up page (#2003) ## Purpose Placeholder text went away on the sign-up page. This restores the placeholders. ## Summary of Changes 1. Send the placeholders to the component properly. * Bump version no. Add CHANGELOG * hotfix password input * fix test --------- Co-authored-by: Brian J. Geiger <[email protected]> Co-authored-by: Brian J. Geiger <[email protected]> Co-authored-by: futa-ikeda <[email protected]>
adlius
added a commit
that referenced
this pull request
Oct 10, 2023
* Re add institution and preprints discover page; remove registries discover page. (#1985) * Remove ember-parachute; Remove page QP (#1986) * Reword object filter dropdown label (#1979) * Fix branded page query-params (#1992) * [ENG-4660] activeFilters query param (#1990) * activeFilters query param * add activeFilters to other pages * Update app/institutions/discover/controller.ts * [ENG-4656] Special-case is-present type filters (#1994) * Special-case is-present type filters * Remove unused style * Update mirage endpoint * Show provider hero-banner on search page (#1995) * Show provider hero-banner on search page * Allow html entities from institution description * Update institution discover default query options (#1993) * Update institution discover default query options * Update link; Combine default qps * Add accessService qp if appropriate * No labels, just keys * Remove accessService qp to SHARE (#1997) * Use less restrictive filter to fetch non-boolean filters (#1999) * Return sort dropdown for registries and preprints discover (#2000) * Return sort dropdown for registries and preprints discover * Address styling issue for tablet * Address branded registries style issues (#2002) * [ENG-4648] Opt out of SHARE indexing (#1998) * Add allowIndexing attr to user model * Add opt-out panel to user-settings * Add test * Update wording * Use constructor; Match mirage default with BE default * Reroute users to general discover page for preprints/discover and preprints/osf/discover (#2004) * change query param name from cardSearchText to q (#2005) * Institutions header (#2006) * Add id back for search box * Update institution page header * Reroute for registry not found (#2007) * Increase color contrast of link in help tour (#2010) * Merge develop into feature/search phase 2 (#2009) * [ENG-4012] Un-silence deprecation manager-capabilities.modifiers-3-13 (#1889) ## Purpose Un-silence the deprecation `manager-capabilities.modifiers-3-13` and fix the resulting problems ## Summary of Changes 1. Unsilence deprecation 2. Upgrade ember-auto-import to v2 3. Upgrade ember-modifiers 4. Upgrade ember-moment and imports 5. Spread moment around all the engines 6. Refactor modifiers to work with new api for ember-modifiers 7. Remove unused modifier 8. Fix usage of side-effect from ember computed to give ember power select a placeholder in institutional dashboard ## Side Effects If I didn't fix the modifiers right, something may have broken there silently. * Fix the missing asset prefix for ember-auto-import (#1906) ## Purpose Staging2 is broken because we can't find `chunk*.js` and it looks like that's because we need to add our `assetsPrefix` to ember-auto-import to make it work. This fix seems to work locally, but it works locally without the fix, so we'll see what actually happens on staging2. ## Summary of Changes 1. Fix the missing asset prefix * [ENG-4591] Barium/upgrade ember 3.28 (#1899) ## Purpose Upgrade ember to 3.28 ## Summary of Changes 1. Match ember dependencies to `ember new` blueprint 2. Fix all the problems 3. Modify getApiErrorMessage to re-throw in the case of no API error message (some problems fixed h/t @futa-ikeda) * [ENG-4488] Remove ember-cli-clipboard (#1910) ## Purpose Ember-cli-clipboard was doing deprecated things, and upgrading it was a nightmare. The actual functionality is trivial to implement, though, so we've made our own version of its copy button. ## Summary of Changes 1. Add copy button 2. Add tests * Don't re-throw error in getApiErrorMessage (#1911) ## Purpose See if a weird bug gets fixed on staging2 by removing a slightly risky re-throw of error messages. ## Summary of Changes 1. Don't re-throw error message * [No ticket] Throw an error when registries overview page errors (#1912) ## Purpose Help to be able to debug situations where the registries overview page goes to the not-found page inappropriately. ## Summary of Changes 1. Send the error to sentry after transitioning to page not found. * Remove most non-dirty relationships (#1918) ## Purpose When upgrading to ember 3.28, we lost the ability to distinguish between dirty relationships and clean ones when PATCHing a record, so we would send all the relationships. This was a problem because many of the clean relationships in the serializer had null information, which broke the API, because it doesn't like PATCHed relationships with null information. This fixes that by removing any relationship that is just null info in the serializer. We will still sometimes PATCH relationships we don't need to, but the info should be the same and thus not cause problems for the API. ## Summary of Changes 1. Scan for null relationships in osf-serializer and remove them from the request payload. * Fix infinite scrolling loader (#1919) ## Purpose The infinite scroller stopped working because the component that manages if it's in the viewport was not compatible with the new modifiers until it was updated. ## Summary of Changes 1. Update ember-in-viewport * [No ticket] Remove clean relationships from PATCH request (#1925) ## Purpose Properly remove clean relationships from a PATCH request. ## Summary of Changes 1. Get the graph 2. Scan the graph for changes in each relationship in the serializer 3. Remove the relationship from the serializer if there are no changes 4. Types * Make relationships polymorphic (#1928) ## Purpose Make registrations load on basket/barium release ## Summary of Changes 1. Make relationships polymorphic * [ENG-4025] Deprecation: has-block-and-has-block-params (#1909) ## Purpose - Address deprecation: [has-block-and-has-block-params](https://deprecations.emberjs.com/v3.x#toc_has-block-and-has-block-params) ## Summary of Changes - Remove `ember-cli-password-strength` and use `zxcvbn` directly - Remove `ember-promise-helpers` as it doesn't seem to be used - Update liquid-fire - Update ember-radio-buttons - Remove deprecation silencer Co-authored-by: Brian J. Geiger <[email protected]> * Remove test that accidentally merged in (#1977) * [ENG-4013] Barium/deprecation this property fallback (#1970) ## Purpose Eliminate this-property-fallback deprecation errors. Might want to review this commit-by-commit. The removal of ember-get-config added a bunch of noise. ## Summary of Changes 1. Upgrade ember-sortable 2. Fix tests that failed this deprecation 3. Upgrade: - ember-cli-showdown - tag-input - Ember-collapsible-panel - Ember-content-placeholders - Ember-radio-button 4. Remove ember-get-config 5. Move environment.d.ts 6. Fix tests * remove 'argument-less-helper-paren-less-invocation' (#1978) * Unsilence deprecation route-render-template (#1984) ## Purpose Fix deprecation route-render-template ## Summary of Changes 1. Unsilence the deprecation * Fix `ember.built-in-components.import` deprecation by upgrading ember-flatpickr (#1982) * fix deprecation by upgrading ember-flatpickr * use null as date param for ember-flatpickr * Fix `deprecated-run-loop-and-computed-dot-access` by upgrading ember-responsive and ember-intl; fix `ember.built-in-components.legacy-arguments` (#1983) * Fix `ember.built in components.legacy-attribute-arguments`; Fix `ember.built-in-components.reopen` (#1987) * Try to fix selenium test (#1988) ## Purpose Try to fix a selenium test that was broken when we re-wrote the clipboard button. ## Summary of Changes 1. Add data selector * Update ember-composable-helpers (#1980) ## Purpose There are two major parts to fixing the try-invoke deprecation. The first is updating ember-composable-helpers, and the second is removing ember parachute. This handles the first. The second will be part of Search Phase 2 once the branded registries discovery page, which is the page that uses ember-parachute, is removed. ## Summary of Changes 1. Update ember-composable-helpers * Fix broken meetings searches (#1991) ## Purpose A recent deprecation fix caused meetings searches to break. This should fix that. ## Summary of Changes 1. Add `target` string to `on` actions * Fix some build-time deprecations (#1989) ## Purpose Fix some build-time deprecations. Everything I know about except for https://deprecations.emberjs.com/v3.x/#toc_ember-global ## Summary of Changes 1. Upgrade ember power select 2. Upgrade Node 3. Remove node-sass 4. Remove ember-component-attributes 5. Fix usage of htmlSafe 6. Upgrade ember-cli-string-helpers 7. Remove unused osf-logo component 8. Update and remove various other dependencies ## Side effects Builds may be a bit faster. I'm getting between 45 and 60ish second builds, although this may only be true for M1 and M2 chips. Could be slower on Intel. Also, we'll get a bunch of extraneous notices in the buld process like `unexpectedly found "<Pane" when slicing source, but expected "class"`. This is unfortunate but expected and isn't supposed to hurt anything. * [ENG-4293] Fix node license validation (#1996) * fix node license validation * remove comments * add test * revert changes to copyMetadataChangesToDraft * Restore placeholder text on sign-up page (#2003) ## Purpose Placeholder text went away on the sign-up page. This restores the placeholders. ## Summary of Changes 1. Send the placeholders to the component properly. * Bump version no. Add CHANGELOG * hotfix password input * fix test --------- Co-authored-by: Brian J. Geiger <[email protected]> Co-authored-by: Brian J. Geiger <[email protected]> Co-authored-by: futa-ikeda <[email protected]> * fix query param (#2011) * Search a11y (#2012) * Add/update aria attributes * Use darker color for object filter links * Institutions updates (#2013) * Remove All as option for instition discover page * Use new iris field for institution identifiers * Change institution default filters by object type * Add back accessService to SHARE request (#2014) * Add back accessService to SHARE request * Move accessService logic to share-adapter * Search: Mobile fixes (#2016) * Add global-classes for use in admin app to modify provider descriptions * Use institution banner image for all size screens * Prevent covering help text on mobile * Darken institution description links (#2015) * Result counts (#2017) * Show results counts for mobile preprint/registry discover page * Grammar for result counts * Search bug fixes (#2019) * Update config import path * Prevent defaultQPs from overwriting left panel filters * Institution discover page-title * Update search styles (#2021) * well it's a fix, sort of (#2023) * Add specificity to supposedly important rules (#2025) --------- Co-authored-by: Yuhuai Liu <[email protected]> Co-authored-by: Brian J. Geiger <[email protected]> Co-authored-by: Brian J. Geiger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Eliminate this-property-fallback deprecation errors. Might want to review this commit-by-commit. The removal of ember-get-config added a bunch of noise.
Summary of Changes
Side Effects
Always possible
QA Notes
Mostly make sure you can drag and drop contributor order in collections and draft registrations.