Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix search improvements topbar on hover #1975

Conversation

chth0n1x
Copy link
Contributor

@chth0n1x chth0n1x commented Aug 29, 2023

-GitHub branch: feature/search-improvements-topbar-hover

Purpose

The purpose of these changes was to fix the active and hover states of the search top bar and the excessive margin on the open badges list div inside the result card containers.

Summary of Changes

  • Calculations for text width was taken into account for each of the topbar elements
  • Styling was applied for topbar when client browser window is resized between full desktop view and tablet screens

Screenshot(s)

image

Figure 1: Topbar with corrected active and hover states on full desktop mode

image image

Figure 2, 3: Topbar with corrected active and hover state at resizing before tablet dimensions

Side Effects

This will affect the overall UI of the search topbar. Testing should include changes to it and the surrounding layout.

QA Notes

  1. Does the UI look like the mock-ups? Should anything be added/removed: https://preview.uxpin.com/e2821be91003954dec0c29a026bc49989b868e2d#/pages/162679105/simulate/no-panels?mode=i

@adlius adlius closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants